splewis / get5

CS:GO Sourcemod plugin for competitive matches/scrims
GNU General Public License v3.0
557 stars 174 forks source link

Fix problems with game going directly to live, skipping countdown #880

Closed nickdnk closed 2 years ago

nickdnk commented 2 years ago

A lovely race condition issue here.

On the current 0.10 release, there is a bug where if you time your !swap or !stay command "right", it will land in the 1 second gap between the plugin changing to "waiting for knife decision" and actually going into warmup, which will send the game directly into live. This in itself is not so terrible, but this also means that the OnRoundStart event fires with g_RoundNumber set to 1 for the first round, where it should be 0. This breaks basically anything reading that forward, including the default MySQL extension.