search

splewis / get5

CS:GO Sourcemod plugin for competitive matches/scrims
GNU General Public License v3.0
558 stars 176 forks source link

Add more event data #895

Closed nickdnk closed 1 year ago

nickdnk commented 1 year ago
  1. Adds time_until_restore to Get5_OnSeriesResult, so a server management system knows how long to wait until the server is available after a match ends.
  2. Adds Get5_OnDemoUploadEnded which fires when the demo upload either fails or succeeds, again letting a server management system know when this has completed so the server can be shut down.

Tested and works as expected.

nickdnk commented 1 year ago

@PhlexPlexico Any opinions on this? I was a little conflicted about the naming of some of these things, for instance; I didn't want to call it "Get5_OnDemoUploadCompleted" as it also fires when it fails, and that would imply success.

PhlexPlexico commented 1 year ago

LGTM. We could try Get5_OnDemoUploadFinished instead? Finishing can either indicate failure or completion as well, and it keeps in line with the other Get5_OnDemoFinished? If not, this still looks acceptable :)

nickdnk commented 1 year ago

LGTM. We could try Get5_OnDemoUploadFinished instead? Finishing can either indicate failure or completion as well, and it keeps in line with the other Get5_OnDemoFinished? If not, this still looks acceptable :)

I did think of that, but I still feel like "finished" implies success and it also means it has almost the same name as the other one, which might cause them to be mistaken for one another.

Edit: In a perfect world I also would have named the recording one better, but I don't want to BC just for that.

PhlexPlexico commented 1 year ago

That's fair then. It's just cutting into the weeds of semantics, so this should be good to merge in :)