splewis / get5

CS:GO Sourcemod plugin for competitive matches/scrims
GNU General Public License v3.0
558 stars 176 forks source link

Update french translation #898

Closed Gryfenfer97 closed 1 year ago

Gryfenfer97 commented 1 year ago

Update the french translation for get5 0.11

I highly thank Maruchun0 for his help (as we can't put 2 names in a commit).

Iwhite67 commented 1 year ago

In my week, i check all

nickdnk commented 1 year ago

@Iwhite67 @Gryfenfer97 You have two PRs for French open right now. We only need one. @Iwhite67, can you suggest your changes to this one instead?

Iwhite67 commented 1 year ago

@Iwhite67 @Gryfenfer97 You have two PRs for French open right now. We only need one. @Iwhite67, can you suggest your changes to this one instead?

i have pull from file of gryfenfer to edit, and i have edit 48 lines

nickdnk commented 1 year ago

We're going to get conflicts that way. Please suggest your edits in this PR as a review.

Iwhite67 commented 1 year ago

Other correction

https://github.com/splewis/get5/blob/70806f14b54e3f92e3c2d82807593bb0f97b8472/translations/fr/get5.phrases.txt#L13 "Entrez {1} quand vous êtes prêt(e) à restaurer la sauvegarde du match."

https://github.com/splewis/get5/blob/70806f14b54e3f92e3c2d82807593bb0f97b8472/translations/fr/get5.phrases.txt#L313 "Les maps ont été décidées : "

https://github.com/splewis/get5/blob/70806f14b54e3f92e3c2d82807593bb0f97b8472/translations/fr/get5.phrases.txt#L377 "Selectionnez une map à JOUER : "

https://github.com/splewis/get5/blob/70806f14b54e3f92e3c2d82807593bb0f97b8472/translations/fr/get5.phrases.txt#L381 "Confirmez que vous souhaitez la jouer {1} : "

https://github.com/splewis/get5/blob/70806f14b54e3f92e3c2d82807593bb0f97b8472/translations/fr/get5.phrases.txt#L385 "Selectionnez une map à BANNIR : "

https://github.com/splewis/get5/blob/70806f14b54e3f92e3c2d82807593bb0f97b8472/translations/fr/get5.phrases.txt#L389 "Confirmez que vous souhaitez la bannir {1} : "

https://github.com/splewis/get5/blob/70806f14b54e3f92e3c2d82807593bb0f97b8472/translations/fr/get5.phrases.txt#L397 "Confirmez que vous voulez commencer {1} : "

nickdnk commented 1 year ago

@Gryfenfer97 Just a bump here. I know it hasn't been very long. Can you take a look at these corrections? I would like to merge this in soon.

Gryfenfer97 commented 1 year ago

Other correction

https://github.com/splewis/get5/blob/70806f14b54e3f92e3c2d82807593bb0f97b8472/translations/fr/get5.phrases.txt#L13

"Entrez {1} quand vous êtes prêt(e) à restaurer la sauvegarde du match."

https://github.com/splewis/get5/blob/70806f14b54e3f92e3c2d82807593bb0f97b8472/translations/fr/get5.phrases.txt#L313

"Les maps ont été décidées : "

https://github.com/splewis/get5/blob/70806f14b54e3f92e3c2d82807593bb0f97b8472/translations/fr/get5.phrases.txt#L377

"Selectionnez une map à JOUER : "

https://github.com/splewis/get5/blob/70806f14b54e3f92e3c2d82807593bb0f97b8472/translations/fr/get5.phrases.txt#L381

"Confirmez que vous souhaitez la jouer {1} : "

https://github.com/splewis/get5/blob/70806f14b54e3f92e3c2d82807593bb0f97b8472/translations/fr/get5.phrases.txt#L385

"Selectionnez une map à BANNIR : "

https://github.com/splewis/get5/blob/70806f14b54e3f92e3c2d82807593bb0f97b8472/translations/fr/get5.phrases.txt#L389

"Confirmez que vous souhaitez la bannir {1} : "

https://github.com/splewis/get5/blob/70806f14b54e3f92e3c2d82807593bb0f97b8472/translations/fr/get5.phrases.txt#L397

"Confirmez que vous voulez commencer {1} : "

I don't think the space after the colons are useful as nothing is printed after them. It's just an indication that there is an action to do.

nickdnk commented 1 year ago

@Gryfenfer97 Have you seen the suggested edits from @Iwhite67 ? If yes; are you both in agreement about the current state of the translation? As you can see, I commented on the places where you did not submit the same texts. Please let me know when you can, as I have no way to follow up myself since I don't speak French.