splewis / get5

CS:GO Sourcemod plugin for competitive matches/scrims
GNU General Public License v3.0
558 stars 176 forks source link

Don't trigger auto-forfeit during warmup/veto + add option to disable forfeit #908

Closed nickdnk closed 1 year ago

nickdnk commented 1 year ago

The auto-forfeit timer is now never started during warmup/veto. You will now have to use get5_time_to_start if you want that phase to be limited in duration instead. Previously, the surrender timer would still start during warmup if get5_time_to_start was 0, which is both confusing/hard to document and also meant that matches may easily be incorrectly ended if someone joins during warmup and leaves for whatever reason, technical or other, without coming back within the grace period. It was not a good design decision.

I also removed a bit of redundancy in the timer-logic and increased the default forfeit countdown (get5_forfeit_countdown) from 60 to 180 seconds.

nickdnk commented 1 year ago

Reminder: If one team leaves, the other team leaves, first team comes back and their timer is stopped, a new timer if the other team is still empty should start.