splewis / get5

CS:GO Sourcemod plugin for competitive matches/scrims
GNU General Public License v3.0
558 stars 176 forks source link

[Feature Request] Score command to get current core and status from rcon #917

Open JustinBenedick opened 1 year ago

JustinBenedick commented 1 year ago

I just ran a cs:go tournament with get5 and it went pretty smooth and the auto vote and map changes were big help over my previous solution warmod. The one thing that i need is a way to see the score via rcon or on command in the console. I also need this to work when the match is over.

I am thinking a command like get5_score could output : "TEAMNAME1" (CT) 7 "TEAMName2" (t) 4 . Map 2 Round 12 Mapscore teamname1 1 -1 teamname2

Or in the case the case the match is over :

Winner: TEAM 1
map 1: de_aztect: team1 16 team2 8 map 2: de_dust team1 7 team 2 16 map 2: de_nuke teeam1 16 team2 3

nickdnk commented 1 year ago

Hello

Right out of the gate: You will not be able to get the score of a match that has ended via RCON. We're likely not going to add that as it would require substantial changes to be reliable and useful.

You should be able to get most of what you need here using get5_status: https://splewis.github.io/get5/latest/commands/#get5_status

If you want to collect stats from matches, I would recommend you look at the HTTP logging feature that's included in the 0.11 version we're about to release: https://splewis.github.io/get5/dev/events_and_forwards/

You can also dump the stats to disk or save data directly in MySQL: https://splewis.github.io/get5/dev/stats_system/

nickdnk commented 1 year ago

Also, I would recommend you join the Discord if you want to be involved with development and testing of new features: https://discord.gg/zmqEa4keCk.

JustinBenedick commented 1 year ago

The tournament we just held was our first time with Get5, we didn't have time to add in hooks for sql or html. It was just sourcemod/metamod and the plugin. During the event the command get5_status did give me info I need but during the tournament it was a bit hard to read. It just presented too much information. I couldn't read it with a quick glance.

The other thing that happened is that once a team wins the whole match the plugin just idles and will not allow me to show scores. I use that get5_status command and it gives me nothing. I had this issue with the wamod plugin years ago and the dev just updated the plugin to include a line for "previous match" in the scores command.

Also I usually run my servers within docker so log files are not readily accessible since they are in containers. I am planning on talking to my team about using sql or something to grab the data. I am already in the discord server.

nickdnk commented 1 year ago

The tournament we just held was our first time with Get5, we didn't have time to add in hooks for sql or html. It was just sourcemod/metamod and the plugin. During the event the command get5_status did give me info I need but during the tournament it was a bit hard to read. It just presented too much information. I couldn't read it with a quick glance.

While JSON is human-readable, this implementation is meant to be read by a service communicating with the server. Having too much information is something you would solve on your end by displaying only the info you need.

The other thing that happened is that once a team wins the whole match the plugin just idles and will not allow me to show scores. I use that get5_status command and it gives me nothing. I had this issue with the wamod plugin years ago and the dev just updated the plugin to include a line for "previous match" in the scores command.

Get5 does not retain state of previous matches in-memory, and it won't do that in the future either. If you need to extract stats from previous games, you must use one of the provided options; HTTP event logging, MySQL integration or dumping stats to disk and reading them at any time.

Also I usually run my servers within docker so log files are not readily accessible since they are in containers. I am planning on talking to my team about using sql or something to grab the data. I am already in the discord server.

You can map the log directory of the container to a directory on your docker host if you want to retain the log files. This goes for the stats-dump file also. You can read about the stats system here: https://splewis.github.io/get5/dev/stats_system/