splewis / get5

CS:GO Sourcemod plugin for competitive matches/scrims
GNU General Public License v3.0
557 stars 176 forks source link

Fix problems/inconsistencies with team loading #945

Closed nickdnk closed 1 year ago

nickdnk commented 1 year ago

A couple of things fixed here:

  1. get5_loadteam would allow you to load coaches into the spectator team.
  2. Prevents recursion in fromfile when loading teams.
  3. Properly use MatchConfigFail event when there are problems loading teams.
  4. Allow get5_loadteam to read JSON team files (as it should).
  5. Prevent using get5_loadteam for team2 in scrim mode.
  6. Update teams (move players) after using get5_loadteam.
  7. Prevent suicide/team swap during warmup from readying up players if get5_auto_ready_active_players is enabled.
  8. Allow spectators in match config to also use fromfile similarly to teams.
  9. Fix string[] vs [string] for maplist in docs. (@thelitlej)
  10. Add "Team" header to fromfile example, as that seems to be required for KV to work (Closes https://github.com/splewis/get5/issues/942)
  11. Allow mixing fromfile file types, i.e. loading a JSON team file from within a KV match config and vice-versa.
nickdnk commented 1 year ago

Tested and seems to be working. Tested various fromfile and errors etc. Haven't found any problems.

caiopolito commented 1 year ago

Done a few tests, seems ok from all aspects.