splewis / get5

CS:GO Sourcemod plugin for competitive matches/scrims
GNU General Public License v3.0
557 stars 176 forks source link

[Feature Request]: Force kick after get5_endmatch #984

Closed LowArte closed 1 year ago

LowArte commented 1 year ago

Prereleases & Documentation

Get5 Version

0.12.1

The Feature

I need to force kick players after get5_endmatch. I need to write my own plugin to do this ?

nickdnk commented 1 year ago

You can just do get5_endmatch;kick @all in that case.

LowArte commented 1 year ago

Thanks for answer. I try, but get error

photo_2023-02-18_14-03-08

nickdnk commented 1 year ago

You may need the basecommands.smx plug-in from SourceMod enabled for it to work. See https://wiki.alliedmods.net/Admin_commands_(sourcemod).

LowArte commented 1 year ago

Thanks sm_kick worked for me. But I need localization for kick message. So I do modification of Get5MapResultEvent, and use Get5_OnMapResult to handle it. Close Issue. Thanks.

nickdnk commented 1 year ago

Note that you will have to update custom localizations each time you update the plug-in, as we change the strings often. Why do you need localization if players are being kicked? They won't see the message. The message shown after being kicked is already localized.

Edit: Ah, there is of course no message like this if you manually kick people. I didn't think of that. We could perhaps make it an option to kick players when using the get5_endmatch to get the best of both worlds.

LowArte commented 1 year ago

If you can do that will be good. I think you can add one more argument to do it

nickdnk commented 1 year ago

We don't really have a consistent way of providing boolean arguments to commands, so I think I'll just add a Cvar you can change which will change the behavior of the command.

LowArte commented 1 year ago

Okey. I waiting. Reopen Issue

nickdnk commented 1 year ago

Available in 0.13: https://github.com/splewis/get5/releases/tag/v0.13.0