splicemachine / splicectl

GNU Affero General Public License v3.0
2 stars 2 forks source link

splicectl: Enhancement for gatherting logs across pods in a workspace #20

Closed RileyMcCuen closed 3 years ago

RileyMcCuen commented 3 years ago

Description

The addition of the splicectl get logs command allows a user to easily grab multiple logs according to a specified selector without having to enumerate each one using the kubectl logs command.

Motivation and Context

Grabbing a set of related logs is now much quicker than it was before because it can be done in a single command. I ran the command with the all flag set: splicectl get logs ... --all and the who process took about 10 seconds and grabbed around 60 logs. This is much faster than having to grab each log individually using the kubectl cli.

I also attempted to make the command run faster by doing the api calls and file writes asynchronously, however the tool was quickly rate limited by the kubernetes api which throttled my requests. No speedup is likely to be found so the couple seconds it takes to get multiple logs is likely a lower bound.

See DBAAS-5610

Dependencies

How Has This Been Tested?

This has been manually tested against a live database, the output of this command was compared to the output of the kubectl get logs command and no differences were found.

Screenshots (if appropriate)

Checklist

If the pull request includes user-facing changes, extra documentation is required:

Changelog Inclusions

Additions

Changes

Fixes

Deprecated

Removed

Breaking Changes