search

splinesoft / SSDataSources

Flexible data sources for your UITableView and UICollectionView.
Other
199 stars 23 forks source link

Updated for cocoaPods 1.x + #64

Closed kevnm67 closed 7 years ago

kevnm67 commented 8 years ago

Updated the podfile and project to work with cocoaPods 1.x +

segiddins commented 8 years ago

Please use 1.1.1 instead of 1.0, thanks!

kevnm67 commented 8 years ago

@segiddins Done

segiddins commented 8 years ago

You only updated the lockfile, you didn't actually install with 1.1.1 (it would've removed the emoji from the build phase names, for instance)

kevnm67 commented 8 years ago

Sorry about that. I originally installed cocoaPods with homebrew and even after installing 1.1.1 it was using 1.0.

jhersh commented 8 years ago

We'll need to bump the Xcode version in circle.yml, ideally to 8.0, to get this building.

jhersh commented 8 years ago

Thanks! One test failure to look at:

✗ testBasicEmptyViewVisibility, failed: caught "CALayerInvalidGeometry", "CALayer position contains NaN: [-9.22337e+18 nan]"
kevnm67 commented 8 years ago

@jhersh Not sure why that 1 test case fails on circle. Any ideas? Locally, it succeeds. I added a link to a possibly related issue.

jhersh commented 8 years ago

Try initializing the emptyView in testBasicEmptyViewVisibility with a nonzero frame:

...
    arrayDataSource.emptyView = [[UIView alloc] initWithFrame:CGRectMake(0, 0, 100, 100)];
...
kevnm67 commented 8 years ago

@jhersh Updated empty view initializations to use a non-zero frame. Thanks for the suggestion ;)

jhersh commented 8 years ago

Looks like we'll need to update the xcodebuild args in circle.yml. Let's change

-destination "platform=iOS Simulator,name=iPhone 6"

to

-destination "platform=iOS Simulator,id=23C6B49D-AF9A-4EBD-ABF3-A6960149327D"

Thanks!

kevnm67 commented 7 years ago

@jhersh Sorry for the delay. I updated the yml file. Let me know if anything else needs to be changed.

jhersh commented 7 years ago

I guess that UDID is no longer on Circle's devices list? Alas we will need some more (admittedly tedious, silly) massaging of the build commands in circle.yml so that CI can pass.

kevnm67 commented 7 years ago

Weird. The previous changes I made was based off circles device list changes. Of course, the build still failed. I'll try to find a solution later.

kevnm67 commented 7 years ago

@jhersh I updated the circle.yml file based off the example from: https://circleci.com/docs/ios-builds-on-os-x/#customizing-your-build

Check out the list of devices at the top of the page and let me know if you want me to modify the yml file. I didn't see the device UDID originally used in your circle.yml.

kevnm67 commented 7 years ago

@jhersh I commented out the test circle reported as failing. Running them locally works for me.... weird. Any thoughts?

codecov-io commented 7 years ago

Current coverage is 84.87% (diff: 100%)

No coverage report found for master at 9ef0465.

Powered by Codecov. Last update 9ef0465...87749a8