splinter-build / splinter

A series of patches (one per branch) on top of the Ninja project's codebase. Updated periodically.
Apache License 2.0
6 stars 1 forks source link

Use smart pointers! #22

Open shahzadlone opened 5 years ago

shahzadlone commented 5 years ago

This is a big one! Use RAII styled pointers (smart pointers) where ever necessary.

Get rid of raw pointers! Perhaps a good way to do this would be to find every where new and delete are called to hunt these down (also please use make_unique or '''make_sharedrather thannew``` ( this will be a separate patch I guess.)

Please use unique_ptr unless absolutely need to use shared_ptr.

https://github.com/splinter-build/splinter/issues/23