search

splintered-reality / py_trees_ros

ROS extensions and implementations for py_trees
Other
143 stars 40 forks source link

optional rosbag #159

Closed veimox closed 4 years ago

veimox commented 4 years ago

NOTE: This is only for 0.5.x branch, from 1.0 (specifically here) this feature was quietly removed.

Exposes a boolean flag to define whether a rosbag to record itself should be created or not. This feature is convinient when developing or when there are not other rosbagging mechanisims but in our case this is just filling up the disk with data we dont use.

As set, this flag is set to True to keep the backwards compatibility and is up to the dev that makes use of BehaviourTree to define if should be disabled.

stonier commented 4 years ago

Surprised someone didn't PR this already. This served us internally before open sourcing py_trees, but the logging story is very use case dependent and one should not quietly consume a user's disk space without asking for permission.

I'd prefer to default to false, but it's a lose-lose situation: break api vs quietly consume disk space. If I release this version for noetic, I'll consider flipping the default.

stonier commented 4 years ago

Thanks for the PR. Releasing v0.5.21 for kinetic and melodic.