splintered-reality / py_trees_ros

ROS extensions and implementations for py_trees
Other
158 stars 40 forks source link

Add optional node and node name arguments to tree setup #182

Closed sea-bass closed 1 year ago

sea-bass commented 2 years ago

This PR aims to address my request in https://github.com/splintered-reality/py_trees_ros/issues/181.

Specifically, I added a few extra arguments to the setup() method of py_trees_ros.trees.BehaviourTree:

This makes it so that I can create a derived class from Node that internally creates a behavior tree, and it can declare parameters / get parameter values ahead of the setup stage.

stonier commented 1 year ago

Thanks for seeding this!

I've broken this PR into three separate PR's (see below), so closing this one out in favour of those.

sea-bass commented 1 year ago

Appreciate the cherry-picks, as now I don't have much to do but sit back, wait for the releases, and update my downstream repo when the time comes. Thanks!

stonier commented 1 year ago

No worries. I'm tracking the next ros-ecosystem release over in https://github.com/splintered-reality/py_trees_ros/issues/174#issuecomment-1368347644.