splintered-reality / py_trees_ros

ROS extensions and implementations for py_trees
Other
143 stars 40 forks source link

Setup with kwargs, just as in py_trees #211

Closed stonier closed 1 year ago

stonier commented 1 year ago

Problem

Kwarg support for setup went into py_trees with https://github.com/splintered-reality/py_trees/commit/20859f21a65232af869540f025573b50122c1ba3.

It didn't propogate through to the ros tree use case.

Proposed Action

Propogate that functionality to the ros tree manager.

Other Notes

ROS behaviours configure themselves from the ros1/ros2 param server. Ostensibly you could have a ROS tree with many non-ros behaviours that need configuring at setup, so this ought to be a valid use case to support.

Question originally raised in #209.

haudren-woven commented 1 year ago

Thank you, this looks great!

stonier commented 1 year ago

Resolved by #212.