search

splintered-reality / py_trees_ros

ROS extensions and implementations for py_trees
Other
143 stars 40 forks source link

[trees] add keyword arguments to setup #212

Closed haudren-woven closed 1 year ago

haudren-woven commented 1 year ago

While the ROS-specific keyword arguments are used, the remainder will be forwarded to the non-ROS tree as-is.

This would solve #211

I tried to keep the change minimal since I don't really know which linters / formatters are necessary for this repository...

stonier commented 1 year ago

LGTM, thanks!

I tried to keep the change minimal since I don't really know which linters / formatters are necessary for this repository...

I added a docstring, but to be honest, this repo has an embarassing lack of formatting, linting and testing. Much of that didn't survive the ros1->ros2 transition along with a few changes over the years with python. I've been correcting that situation back in py_trees as I put everything under poetry, mypy, tox, ufmt and flake, but I haven't got everything setup to do poetry in ros2 yet.

stonier commented 1 year ago

Do you need a release (which rosdistro)?

haudren-woven commented 1 year ago

Thanks! If you get around to making a release for Humble, that'd be great, but no rush I can use the source for now :)