search

splintermind / Dwarf-Therapist

Maintained branch of the original Dwarf Therapist for Dwarf Fortress.
Other
405 stars 71 forks source link

Roles are not calculated for animals #292

Open hanssun07 opened 8 years ago

hanssun07 commented 8 years ago

While it would make sense that using roles on animals work, roles are simply not calculated, resulting in all 0's even after a read, but no error message.

thistleknot commented 8 years ago

Oh dear. Idk if that would work well. I spose it could be done if animals were treated as there own domain. I.e..roles calculated apart from the dwarfs. But it wouldn't break. Just gonna mix all units values together in a massive sorted calculation On Jan 26, 2016 1:48 PM, "RoaryStar" notifications@github.com wrote:

While it would make sense that using roles on animals work, roles are simply not calculated, resulting in all 0's even after a read, but no error message

— Reply to this email directly or view it on GitHub https://github.com/splintermind/Dwarf-Therapist/issues/292.

splintermind commented 8 years ago

That's intended. Roles calculations are somewhat expensive and intended for fortress citizens. As thistleknot pointed out, it would also most likely throw things off for the actual citizens.

Why do you want roles for animals?

hanssun07 commented 8 years ago

I want to be able to sort them by a combination of their stats so I can, for example, pick the top x animals to save and the rest to butcher. I can do something similar with iterative filter scripts, but I can only see the ones that qualify for the filter script and it's really micromanagy to update the script every time changing only one value so I can get the right number.

I realize now that it probably would take therapist three times longer to read. Maybe add a feature to filter scripts so they can do a sort instead?

thistleknot commented 8 years ago

Maybe a checkbox list that allows you to select what races are calculated for in roles (races polled from units avail)? On Jan 27, 2016 5:53 AM, "RoaryStar" notifications@github.com wrote:

I want to be able to sort them by a combination of their stats so I can, for example, pick the top x animals to save and the rest to butcher. I can do something similar with iterative filter scripts, but I can only see the ones that qualify for the filter script and it's really micromanagy to update the script every time changing only one value so I can get the right number.

I realize now that it probably would take therapist three times longer to read. Maybe add a feature to filter scripts so they can do a sort instead?

— Reply to this email directly or view it on GitHub https://github.com/splintermind/Dwarf-Therapist/issues/292#issuecomment-175636917 .

splintermind commented 8 years ago

What kind of things are you filtering on, attributes? Body size?

hanssun07 commented 8 years ago

I'm doing a weighted sum of attributes.

splintermind commented 8 years ago

Yeah then the role calculations would have to be modified to run for livestock, but more importantly, group by race.

Maybe an alternative would be to have a 'scriptable' column, where the script provides the data for cell. The drawing part would be tricky since it needs to scale the values from 0-100 but it may be possible.