splitbee / notion-api-worker

Notion as CMS with easy API access
MIT License
1.56k stars 197 forks source link

Collection fixes #24

Open transitive-bullshit opened 4 years ago

transitive-bullshit commented 4 years ago

While working on adding support for collections to react-notion, I've come across some high level issues.

Beyond this PR, /collection would ideally not take in a pageId but rather a collectionId and collectionViewId since the abstraction of using a page to fetch a collection doesn't really work once you start having more complicated collections and views. This will also be necessary to fetch the data for a specific collection view dynamically since I don't think it makes sense for the initial page content to contain all the data for all collections and their corresponding views.

So I propose the following going forwards:

ThallyssonKlein commented 3 years ago

image

I'm having this error trying to run this pull request

@transitive-bullshit