splitbee / react-notion

A fast React renderer for Notion pages
https://react-notion.com
MIT License
2.86k stars 151 forks source link

Split component into `<NotionPage/>` and `<NotionRenderer/>` #37

Open timolins opened 3 years ago

timolins commented 3 years ago

Now that that react-notion has been out for sometime, two main use-cases have established:

At the moment we do both, but handle the specific use-cases with props like fullPage, which mixes those concerns.

Proposal

Extract some functionality (fullPage, disableHeader) to a new component called <NotionPage/>. This would result in the following benefits:

We are currently beta testing a support for custom components, which should make this separation possible - See #30