search

splitbrain / dokuwiki-plugin-dw2pdf

A fork of Luigi Micco's PDF export plugin for DokuWiki
http://www.dokuwiki.org/plugin:dw2pdf
55 stars 68 forks source link

Proxy support based on DW's main configuration #472

Open emmanuel-benoit opened 1 year ago

emmanuel-benoit commented 1 year ago

Hello, Here is a small patch that solves issue #245 by setting mPDF's curlProxy and curlProxyAuth configuration variables based on Dokuwiki's proxy configuration (if it is set). Kind regards, E.B.

Klap-in commented 1 year ago

Thanks! Looks logic for me, @splitbrain could you have a look as well?

splitbrain commented 1 year ago

Well, in principle this makes sense.

However, preferably dw2pdf would use DokuWiki's own HTTP client instead of relying on curl. That should be possible by implementing our own \Mpdf\Http\ClientInterface

See https://mpdf.github.io/configuration/configuration-v7-x.html#http-client

emmanuel-benoit commented 1 year ago

In this case, please feel free to reject this pull request as I don't have enough time to dig into this at the moment.