search

splitbrain / dokuwiki-plugin-letsencrypt

Request letsencrypt SSL certificates for your DokuWiki
https://www.dokuwiki.org/plugin:letsencrypt
5 stars 1 forks source link

Fix PHP Deprecation and Warning Messages #5

Closed micgro42 closed 5 years ago

micgro42 commented 5 years ago

This fixes two PHP messages in the error logs that were triggered when the cli script was run, for example by cron.

This should work, but I didn't have the opportunity to actually test it.

micgro42 commented 5 years ago

A quick heads up: Turns out, this PR silently broke things, instead of fixing some warnings. The setLogger in cli.php expects a DokuCLI and fails fatallay if it only gets a DokuWiki_CLI_Plugin: https://github.com/splitbrain/dokuwiki-plugin-letsencrypt/blob/a8a01844d78faf31e9b1fe9b9ec56f81ebcbfd9e/cli.php#L66

Not sure why I haven't noticed this earlier. :/ I'll like won't have time to fix this in the coming days, but I'll try to look into it next week.

Please double check your certs, they might get silently not updated.