search

splitbrain / dokuwiki-plugin-statistics

Gather usage/view statistics of a DokuWiki
http://www.dokuwiki.org/plugin:statistics
6 stars 17 forks source link

Check authenticated user role for viewing the graphs. #73

Closed TafkaMax closed 9 months ago

TafkaMax commented 9 months ago

Thank you for fixing the img.php to check if user is authenticated. (https://github.com/splitbrain/dokuwiki-plugin-statistics/issues/72)

I have a new request, for the plugin to honor the role of the authenticated user.

E.g. Only users who have manager or admin role should be able to see the graphs.

I have tested it and users who have normal user role can also still view the graphs.

splitbrain commented 9 months ago

Not sure what you mean. The fix for #72 already uses auth_ismanager() which will check for manager permissions.

TafkaMax commented 9 months ago

Not sure what you mean. The fix for #72 already uses auth_ismanager() which will check for manager permissions.

Ah sorry. I tested it with a user who I thought didn't have manager permissions, but the user actually had manager permissions via a group. My bad. Sorry for wasting your time!