splitbrain / dokuwiki-plugin-translation

Easily setup a multi-language DokuWiki
http://www.dokuwiki.org/plugin:translation
23 stars 24 forks source link

admin page: fix incorrectly inverted conditional #275

Closed stapelberg closed 1 year ago

stapelberg commented 3 years ago

The operator precedence of ! is higher than ===, so commit https://github.com/splitbrain/dokuwiki-plugin-translation/commit/bcbb210f3744a804568845f6a65e23d1a4fe0303 inverted the conditional incorrectly.

Either parens are required, or we use !==, which seems a little more clear to me.

See also https://www.php.net/manual/en/language.operators.precedence.php