search

splitbrain / dokuwiki-plugin-vshare

Plugin to easily embed videos from various video sharing sites into DokuWiki
http://www.dokuwiki.org/plugin:vshare
17 stars 19 forks source link

add support to niconico #42

Closed leeyc0 closed 7 years ago

leeyc0 commented 7 years ago

I discovered that niconico has changed it embedding syntax, and vshare can now serve niconico by adding single line in sites.conf:

niconico        iframe  http://embed.nicovideo.jp/watch/@VIDEO@

As such, I am deprecating my niconico plugin. May you add this line in sites.conf?

Historically the niconico embedding syntax is too obscure that vshare cannot serve it and I had to write my plugin to solve the problem. Since niconico uses now standard iframe instead of obscure code, my plugin has finished the historical role and in favour of using vshare now.

splitbrain commented 7 years ago

Can you open a pull request? Also check if they support SSL and use the protocol independent //embed.nicovideo.jp/watch/@VIDEO@ then.

leeyc0 commented 7 years ago

Opened PR #43. Also adds support to Chinese video sites youku, tudou and bilibili. All do not support HTTPS including niconico.

leeyc0 commented 7 years ago

Oh I forgot to update sites.js for the pattern. I need to close #43 first PR first and will submit another later.

leeyc0 commented 7 years ago

open PR #44