splitgraph / seafowl

Analytical database for data-driven Web applications 🪶
https://seafowl.io
Apache License 2.0
392 stars 9 forks source link

Bump object_store to 0.5.6 #371

Closed onpaws closed 1 year ago

onpaws commented 1 year ago

I originally expected we would have to fork object_store to benefit from bcfe63ec5b0420b030e45091b8fc7c79e091646a but upon digging deeper I learned it was already released, at least as of v0.5.6.

So this PR seeks to bring in that change and hopefully fix the GCS bug. Will post back findings 🤞

mildbyte commented 1 year ago

Thanks! Mildly surprised that this is not reflected in Cargo.lock - did you forget to run cargo update?

image

I originally expected we would have to fork object_store to benefit from bcfe63ec5b0420b030e45091b8fc7c79e091646a

You could also have pointed to a certain commit in the original arrow repo instead of forking it:

object_store = { git = "https://github.com/apache/arrow-rs", rev="bcfe63ec5b0420b030e45091b8fc7c79e091646a" }

or even (since the commit is on master)

object_store = { git = "https://github.com/apache/arrow-rs" }

But in any case, that probably wouldn't have patched transitive dependencies (e.g. the version of object_store that datafusion depends on), which is why we need to see what happens when the lock file is actually updated.

onpaws commented 1 year ago

Closing in favor of 030d1086293becb4a4e6f54323e3231acd6d3af0 Thank you @gruuya