Closed onpaws closed 1 year ago
LGTM 👍
Was about to merge but at the last second I observed a pre-commit discrepancy between local (works) vs GHA CI ( observing this).
I tried running rustup update
to pull in latest nightly, followed by cargo clippy --all-targets --workspace -- -D warnings
which led me to observe this:
error: use of `default` to create a unit struct
--> src/context.rs:1011:50
|
1011 | FileType::AVRO => Arc::new(AvroFormat::default()),
| ^^^^^^^^^^^ help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
= note: `-D clippy::default-constructed-unit-structs` implied by `-D warnings`
error: could not compile `seafowl` (lib) due to previous error
warning: build failed, waiting for other jobs to finish...
error: could not compile `seafowl` (lib test) due to previous error
So the intention of 9137aaa is an experiment to resolve that issue. Let's see 🍿
EDIT: looks like it passed
EDIT2: as did the rest of the CI build.
Therefore unless objections, I'm intending to merge. Please give me a shout if the AvroFormat
change is a problem.
Merging. Thanks for the review!
Prototype seafowl.toml
TODO
[x] Refine the way we reference the GOOGLE_APPLICATION_CREDENTIALS JSON file Am currently passing it in via env var only, e.g.
Marco: you can provide an opti[o]nal parameter in the GCS config to specify the path to the JSON creds
and if that is missing try to fetch it from the env vars
and if that fails error out
[x] Test coverage. Consider adding this underneath docker-compose.yaml minio section