Support DROP FUNCTION - Githubissues

splitgraph / seafowl

Analytical database for data-driven Web applications 🪶

https://seafowl.io

Apache License 2.0

388 stars 9 forks source link

Support DROP FUNCTION #457

Closed onpaws closed 11 months ago

onpaws commented 11 months ago

[x] Add support DROP FUNCTION [IF EXISTS] $myfunction
[x] Test it against 1 function
[x] Test it against >1 function
[x] Ensure error handling is where it needs to be
[x] Add tests

onpaws commented 11 months ago

Tested:

CREATE FUNCTION

./create_udf.sh
HTTP/1.1 200 OK
x-seafowl-query-time: 355
vary: Authorization, Content-Type, Origin, X-Seafowl-Query
transfer-encoding: chunked
date: Fri, 28 Jul 2023 21:39:26 GMT

DROP FUNCTION

./delete_udf.sh
HTTP/1.1 200 OK
x-seafowl-query-time: 388
vary: Authorization, Content-Type, Origin, X-Seafowl-Query
transfer-encoding: chunked
date: Fri, 28 Jul 2023 21:38:48 GMT

gruuya commented 11 months ago

Very nice!

onpaws commented 11 months ago

Unless objections, intending to merge this later today, and also the marketing/docs PR

@mildbyte OK to push the button? Anything need attention?

mildbyte commented 11 months ago

@onpaws Just a small cleanup / nitpick. LGTM, thanks!