splitio / ios-client

iOS SDK client for Split Software
https://split.io
Other
11 stars 18 forks source link

Fix SwiftLint 0.57.0 errors #591

Closed alexfu closed 3 days ago

alexfu commented 3 days ago

Our codebase recently started failing in CI because it could not successfully build the Split SDK.

After further investigation, we were able to determine that the root cause is from SwiftLint errors and more specifically, SwiftLint errors when using SwiftLint 0.57.0. GitHub recently updated their macos-14 runner to use SwiftLint 0.57.0, see here.

What did you accomplish?

Fixed a handful of SwiftLint errors that have appeared in SwiftLint 0.57.0 using the --fix flag. These are all whitespace related errors.

How do we test the changes introduced in this PR?

Run swiftlint. Confirmed that running SwiftLint 0.56.2 and 0.57.0 resulted in 0 errors.

Extra Notes

Once this is merged, it would be great if a new release could be deployed so that our builds can start passing in CI.

javrudsky commented 3 days ago

Thank you @alexfu !