splitio / split-synchronizer

Golang agent for Split SDKs
Other
16 stars 15 forks source link

impressionsPostRate cannot be reduced #147

Closed rmelick-vida closed 2 years ago

rmelick-vida commented 3 years ago

The Runbook seems to say that one solution for improving impressions throughput is to decrease the impressionsPostRate

In Example 2 and 3, they give examples of decreasing the rate to 30 seconds or 15 seconds.

However, when attempting to configure it to 30 seconds, I get the following error:

Split Synchronizer - Initialization error: ImpressionsPostRate must be >= 60. Actual is: 30

Seems like the documentation does not match the code.

rmelick-vida commented 3 years ago

I also noticed that my synchronizer seemed to be defaulting the ImpressionsPostRate to 300 seconds, instead of the documented 60, when I checked the /admin/userConfig endpoint

chillaq commented 3 years ago

Hi @rmelick-vida, Thanks for the info, that is correct, the 60 second minimum was introduced if ImpressionMode parameter is set to OPTIMIZED, if the ImpressionMode is set to DEBUG, it will allow lower than 60.

We will update the Runbook.

chillaq commented 3 years ago

Hi @rmelick-vida regarding the ImpressionsPostRate default value, the latest Synchronizer build is 60, can you confirm you got the latest build?

rmelick-vida commented 3 years ago

Hi @chillaq , I was running 4.0.2, perhaps that explains the difference? I was able to successfully configure it down to 60, which meets my needs right now.