search

splitwise / TokenAutoComplete

Gmail style MultiAutoCompleteTextView for Android
Apache License 2.0
1.3k stars 384 forks source link

Potential license issue in FilteredArrayAdapter.java #355

Closed iragsdale closed 6 years ago

iragsdale commented 6 years ago

Hi, just wanted to bring your attention to a potential licensing issue in FilteredArrayAdapter.java.

My company is evaluating use of this project and flagged that file as having an "unknown" license. Because it was originally from the linked gist (https://gist.github.com/tobiasschuerg/3554252), and the gist has no declared license, apparently technically it cannot be included in other projects.

I'm sure this my company being overly pedantic, and I have commented on that gist asking the author to confirm that he's fine with including it in an Apache licensed project, just wanted to make sure you were aware.

mgod commented 6 years ago

Hmmm, well I included the link to the original gist as a reference for myself if I ran into any issues with my implementation of the code, not where I copied the file from. The FilteredArrayAdapter in the project here is all my own work. I hope a reasonable reading of the two source files show that the implementations are pretty different. Was it just including the link that flagged this file as an issue?

iragsdale commented 6 years ago

That must be the case! I didn't actually do a diff, we're using a tool (Black Duck) that searches for potential issues, sometimes they get it wrong. Thank you for the fast response, I'll ask them to re-evaluate. Very sorry for any confusion.

iragsdale commented 6 years ago

And thank you so much for making this project available to begin with, I really appreciate you sharing your code with the world!

mgod commented 6 years ago

You're welcome! If you get feedback on why Black Duck has an issue with the file, please let me know! Some of the file contents are required to match the Android API, but I can tweak a lot of the rest of it to avoid a false positive here.