Migrate to Android X - Githubissues

splitwise / TokenAutoComplete

Gmail style MultiAutoCompleteTextView for Android

Apache License 2.0

1.3k stars 384 forks source link

Migrate to Android X #399

Closed scottyab closed 4 years ago

scottyab commented 4 years ago

Addresses #362

Migrate to Android X.
Build and Target version to 28
source and target compatibility to java 1.8
Gradle plugin updated to 3.4.2

I also bumped the version to 4.0.0 given this will likely be a breaking change for some users of the library.

scottyab commented 4 years ago

Likely some Circle CI config needs updating to use compile SDK 28 and newer buildtools but wasn't 100% sure on this.

cketti commented 4 years ago

@mgod Is there anything that still needs to be done before this PR can be merged? I'm happy to help with whatever work is necessary.

mgod commented 4 years ago

Nope, sorry. Just intend to have this as part of a 4.0 release with a couple of other breaking changes, so planning got a little bigger than just this change.

mgod commented 4 years ago

I'll put together a 4.0-beta01 release for this so you can get it running until I have time to review other details

mgod commented 4 years ago

You can now grab com.splitwise:tokenautocomplete:4.0.0-beta01@aar. I'm also considering migrating to Kotlin for everything. Would this be a problem for you?

cketti commented 4 years ago

I'm also considering migrating to Kotlin for everything. Would this be a problem for you?

I'm proposing to use emoji reactions for the answer to this question.

:+1: Not a problem for me. Kotlin all the things! :-1: I'd prefer the library sticking to Java

Personally, I'd welcome a switch to Kotlin.