search

splix / polkaj

Library to access and build for Polkadot using Java
Apache License 2.0
60 stars 53 forks source link

Support for Polkadot v0.8.28 #50

Closed pablojorge closed 3 years ago

pablojorge commented 3 years ago

This PR adds support for two changes introduced in v0.8.28 (https://github.com/paritytech/polkadot/releases/tag/v0.8.28):

A new MultiAddress class that takes the place and wraps the original Address is introduced. The BalanceTransfer and Extrinsic classes now contain a reference to a MultiAddress, and for backward compatibility, we keep setters that accept a plain Address instance.

codecov-io commented 3 years ago

Codecov Report

Merging #50 (5d09ba6) into master (b2d8775) will increase coverage by 0.13%. The diff coverage is 94.44%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #50      +/-   ##
============================================
+ Coverage     86.91%   87.04%   +0.13%     
- Complexity      892      911      +19     
============================================
  Files           115      118       +3     
  Lines          2973     3034      +61     
  Branches        430      438       +8     
============================================
+ Hits           2584     2641      +57     
  Misses          278      278              
- Partials        111      115       +4
Impacted Files Coverage Δ Complexity Δ
.../io/emeraldpay/polkaj/scaletypes/MultiAddress.java 87.50% <87.50%> (ø) 2.00 <2.00> (?)
...in/java/io/emeraldpay/polkaj/scale/UnionValue.java 94.44% <87.50%> (-5.56%) 12.00 <7.00> (+7.00) :arrow_down:
...a/io/emeraldpay/polkaj/scaletypes/AccountInfo.java 100.00% <100.00%> (ø) 17.00 <5.00> (+3.00)
...meraldpay/polkaj/scaletypes/AccountInfoReader.java 100.00% <100.00%> (ø) 2.00 <0.00> (ø)
.../emeraldpay/polkaj/scaletypes/BalanceTransfer.java 74.07% <100.00%> (+2.07%) 15.00 <1.00> (+1.00)
...ldpay/polkaj/scaletypes/BalanceTransferReader.java 100.00% <100.00%> (ø) 2.00 <0.00> (ø)
...ldpay/polkaj/scaletypes/BalanceTransferWriter.java 100.00% <100.00%> (ø) 3.00 <1.00> (+1.00)
...ava/io/emeraldpay/polkaj/scaletypes/Extrinsic.java 93.75% <100.00%> (+0.20%) 11.00 <0.00> (ø)
.../emeraldpay/polkaj/scaletypes/ExtrinsicReader.java 84.37% <100.00%> (ø) 2.00 <0.00> (ø)
.../emeraldpay/polkaj/scaletypes/ExtrinsicWriter.java 100.00% <100.00%> (ø) 3.00 <0.00> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b2d8775...5d09ba6. Read the comment docs.

splix commented 3 years ago

@pablojorge sorry, totally missed the Pull Request. Just checked it, everything looks good, and I'm going to merge it now. Thank you!