splondike / polipoid

Android wrapper for the polipo proxy
GNU General Public License v3.0
35 stars 12 forks source link

Update settings interface #12

Closed MarcusWolschon closed 8 years ago

MarcusWolschon commented 8 years ago

In the default configuration the web interface http://localhost:8123/polipo/config? described in the polipo-manual linked to in the settings answersd with "404 not found"

splondike commented 8 years ago

The web interface is deliberately disabled. The issue with leaving it open is that any other application on the system with network permissions can then change your polipo settings. This is why I override any configuration the user has uploaded to explicitly disable it[1].

What were you planning on using the web interface for?

[1] https://github.com/splondike/polipoid/blob/v1.1.0/src/main/java/com/polipoid/backend/proxy/ProxyManager.xtend#L113

MarcusWolschon commented 8 years ago

What about informing the user about this on the config-upload page then? I couldn't find the default config file used to add modifications. That was my attempt to get it, so I didn't have to guess what polipoid meight possibly have in the defaults that my config file would need to contain too.

MarcusWolschon commented 8 years ago

I can't open the page right now but it seems that polipo does contain an access control feature with username and password for it's web interface.

https://www.google.de/url?sa=t&rct=j&q=&esrc=s&source=web&cd=1&ved=0ahUKEwipq6usqc7JAhXIvRQKHaGeAZIQFgggMAA&url=http%3A%2F%2Fwww.pps.univ-paris-diderot.fr%2F~jch%2Fsoftware%2Fpolipo%2Fmanual%2FAccess-control.html&usg=AFQjCNFSyq8VRq_2shXowjAvlzXLxxGBFg&sig2=3KabS4Id4f-PN5cbH-1T8A&cad=rja

splondike commented 8 years ago

What do you think about changing the settings interface to look something like this:

[ <- Settings               : ]
-----------------------------
| # current config here       |
|                             |
|                             |
------------------------------

It shows a full screen textbox containing the current configuration. Up the top right you have the header menu button which would have 'Save settings' and 'Reset to default settings' as options. To cancel your update you'd just press the back button.

The default configuration contents would have a comment up the top linking to the polipo manual and explaining the 'forced' configuration (e.g. disabling the web interface).

MarcusWolschon commented 8 years ago

Cool. Yes, that's very induitive and easy to use.

splondike commented 8 years ago

In the commit I also moved all the discretionary force-overridden settings into the default config instead; I figured the user might as well be allowed to change them.