Not working with Android 5.1

splondike / polipoid

Android wrapper for the polipo proxy

GNU General Public License v3.0

35 stars 12 forks source link

Not working with Android 5.1 #9

Closed ph123 closed 9 years ago

ph123 commented 9 years ago

After pressing "Start proxy", Polipoid close and the "Bug report" is visible

splondike commented 9 years ago

Hey, thanks for letting me know. I haven't had a chance to see if I can replicate this yet, but what is the device model you've got the problem on?

ph123 commented 9 years ago

Hi! It's the Google Nexus 5 with Stock ROM 5.1

splondike commented 9 years ago

The issue is Android 5 requires binary executables to be PIE compatible. This is straightforward to fix with some extra compilation flags. If we go with a pure PIE build this cuts out android < version 16. The solution is to create two executables and decide which one to use based on the android version.

The above version switching will need to be plumbed through to the appropriate class, and the README and fdroid metadata stuff changed.

splondike commented 9 years ago

This has been fixed by the 1.1.0 release (confirmed with ph123 outside of github). Closing.