Unit test for `message_deserialize_response`

splone / splonebox-core

splonebox - open source network assessment tool with focus on modularity

http://splonebox.io

GNU Affero General Public License v3.0

24 stars 7 forks source link

Unit test for `message_deserialize_response` #34

Closed mkind closed 8 years ago

mkind commented 8 years ago

Unit test for message_deserialize_response is missing.

denji commented 8 years ago

[src/api/apikey.c:38]: (error) Resource leak: f
[src/rpc/connection/server.c:148]: (error) Uninitialized variable: server
[src/string.c:41] -> [src/string.c:38]: (warning) Possible null pointer dereference: str - otherwise it is redundant to check it against null.

stze commented 8 years ago

Thanks @denji and cppcheck for reporting this. I'll add a fclose(f) in src/api/apikey.c to close the file descriptor if fread function fails. The server.c:148 error and the warning in src/string.c:41 are cppcheck false positives.