splone / splonebox-core

splonebox - open source network assessment tool with focus on modularity
http://splonebox.io
GNU Affero General Public License v3.0
24 stars 7 forks source link

Make static functions unit-testable #42

Closed stze closed 8 years ago

stze commented 8 years ago

static functions are currently not testable. we need some improvements to make this happen:

#ifdef BOX_UNIT_TESTS
#define STATIC
#else
#define STATIC static
#endif
STATIC void close_cb(uv_handle_t *handle);
STATIC int connection_handle_request(struct connection *con,
    msgpack_object *obj);
STATIC int connection_handle_response(struct connection *con,
    msgpack_object *obj);
STATIC void connection_request_event(connection_request_event_info *info);
STATIC void connection_close(struct connection *con);
STATIC int parse_cb(inputstream *istream, void *data, bool eof);
mkind commented 8 years ago

@stze, can we close the issue?