search

splorp / tersus

An achingly simple WordPress theme without all the usual cruft.
GNU General Public License v3.0
99 stars 6 forks source link

Source Formatting #5

Open danrubin opened 14 years ago

danrubin commented 14 years ago

Just adding this to my list of things to review — I'm a big fan of "view source" looking nice with all the proper levels of indentation, so the output/hierarchy is easier to understand. Might be worth including that, plus a few more instructional comments to inform new users about things like hentry, various classes, why a DIV is used vs. some other element, comments at the top and bottom of every included file, etc.

splorp commented 14 years ago

I like teh pretty too.

cdharrison commented 14 years ago

Most of the source code is formatted pretty well, but could use some touch-up here and there. Inline documentation would be a great idea. Educating users about why things were done a certain way would make this theme an incredible resource.

danrubin commented 14 years ago

I'm not too familiar with how WordPress/PHP handles line endings/tabs, but that's about all I was thinking of cleaning up.

The comments, however, would indeed make this theme (and the others in concert) very useful.

splorp commented 14 years ago

Line endings are generally reliant on the text editor being used and the default format that files are saved in. I’m using BBEdit with all files defaulting to UTF-8 (no BOM) with Unix endings (LF).