I tried, unsuccessfully, to find the correct dsapi in pypi and GitHub, so I could replace that folder with a wheel.
I don't see anything obviously risky with keeping that folder as-is
Testing:
workflow actions for this PR are not green, but I think the failure is acceptable:
The failure is: JSON config param ds_api_key should probably be of data_type password or file
The author seems to have been thoughtful enough to use "data_type": "password" for ds_api_secret_key. It doesn’t feel like it was an accident to use "data_type": "string" for ds_api_key right above it
built and installed a tarball in this SOAR cloud instance (version 5.1.0.68293)
also installed tarball in this SOAR on-prem instance (version 5.1.0.68966)
confirmed that /opt/phantom/apps/digitalshadows_8cebdfd7-afe9-48eb-b840-2d98f860ed79/dependencies/ contains at least all the items from wheels
Please ensure your pull request (PR) adheres to the following guidelines:
Please refer to our contributing documentation for any questions on submitting a pull request, link: Contribution Guide
Pull Request Checklist
Please check if your PR fulfills the following requirements:
[ ] Testing of all the changes has been performed (for bug fixes / features)
[ ] The readme.html and readme.md have been reviewed and added / updated if needed (for bug fixes / features)
[ ] Use the following format for the PR description: <App Name>: <PR Type> - <PR Description>
[ ] Provide release notes as part of the PR submission which describe high level points about the changes for the upcoming GA release.
[ ] Verify all checks are passing.
[ ] Do NOT use the next branch of the forked repo. Create separate feature branch for raising the PR.
[ ] Do NOT submit updates to dependencies unless it fixes an issue.
[ ] Limit your pull request to one application and submit multiple pull requests if necessary.
Pull Request Type
Please check the type of change your PR introduces:
[ ] New App
[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation
[ ] Other (please describe):
Release Notes (REQUIRED)
Provide release notes as part of the PR submission which describe high level points about the changes for the upcoming GA release.
What is the current behavior? (OPTIONAL)
Describe the current behavior that you are modifying.
What is the new behavior? (OPTIONAL)
Describe the behavior or changes that are being added by this PR.
Other information (OPTIONAL)
Any other information that is important to this PR such as screenshots of how the component looks before and after the change.
Pay close attention to (OPTIONAL)
Any specific code change or test case points which must be addressed/reviewed at the time of GA release.
PAPP-20799: added requirements.txt and wheels
Note:
dsapi
in pypi and GitHub, so I could replace that folder with a wheel.Testing:
ds_api_key
should probably be of data_typepassword
orfile
"data_type": "password"
fords_api_secret_key
. It doesn’t feel like it was an accident to use"data_type": "string"
fords_api_key
right above it/opt/phantom/apps/digitalshadows_8cebdfd7-afe9-48eb-b840-2d98f860ed79/dependencies/
contains at least all the items fromwheels
Please ensure your pull request (PR) adheres to the following guidelines:
Pull Request Checklist
Please check if your PR fulfills the following requirements:
<App Name>: <PR Type> - <PR Description>
next
branch of the forked repo. Create separate feature branch for raising the PR.Pull Request Type
Please check the type of change your PR introduces:
Release Notes (REQUIRED)
What is the current behavior? (OPTIONAL)
What is the new behavior? (OPTIONAL)
Other information (OPTIONAL)
Pay close attention to (OPTIONAL)
Screenshots (if relevant)
Thanks for contributing!