Closed yash-metron closed 6 months ago
Thank you for your submission! We have a total of 20 PRs open right now, and we are working hard on all of them! We will take a look as soon as we can.
@yash-metron Static Tests results for commit 387f2343b9bfbf21825977b1001c3a4f96d1ddf3 - https://drive.google.com/file/d/1PiknAyJzIOQy-th1Len8Lg5vmenefK04/view?usp=drivesdk
@yash-metron Compile Tests results for commit 387f2343b9bfbf21825977b1001c3a4f96d1ddf3 - https://drive.google.com/file/d/1XROtCKPiMMhy1dVIu5IkKQFlFShmNEgZ/view?usp=drivesdk
@yash-metron Static Tests results for commit 2c99337f2a8cfe017de500206c9900f5c4751f06 - https://drive.google.com/file/d/1nuN3t3oDtAoWE1guD7K7dXLCTPP31hEK/view?usp=drivesdk
@yash-metron Compile Tests results for commit 2c99337f2a8cfe017de500206c9900f5c4751f06 - https://drive.google.com/file/d/1L68p7V1S4vxRPMaHAEErNT0EFxzBT0pp/view?usp=drivesdk
@yash-metron Static Tests results for commit 4db719dec6e55da4010ee2170ae0db024f49ac0f - https://drive.google.com/file/d/1lZElBQBYvxjCx1bbUJTOr0wmbYuQgzuv/view?usp=drivesdk
@yash-metron Compile Tests results for commit 4db719dec6e55da4010ee2170ae0db024f49ac0f - https://drive.google.com/file/d/1Y7nvriI9-Dyb5t274xvi56YpK3TLg4pd/view?usp=drivesdk
@yash-metron Static Tests results for commit b9d7e906e13dc287ed8650c141b9e9cfd33b99ae - https://drive.google.com/file/d/1Ut9FExQqEfmwLPETu_Sbv6pDghjQ5YSn/view?usp=drivesdk
@yash-metron Compile Tests results for commit b9d7e906e13dc287ed8650c141b9e9cfd33b99ae - https://drive.google.com/file/d/11dUgYhbJgphPB5unGginnLZylcBqsx05/view?usp=drivesdk
@yash-metron Static Tests results for commit abb836c57bb1a057c5438ec6619c21461b66621c - https://drive.google.com/file/d/1nvpWpJ-5HSNqa04hW_FxrWdj6zUBUF29/view?usp=drivesdk
@yash-metron Compile Tests results for commit abb836c57bb1a057c5438ec6619c21461b66621c - https://drive.google.com/file/d/11tVTfGQgZp_DV-2EawKL0sKSzJfMrCBt/view?usp=drivesdk
We tried updating the minimum product version from 5.3.5 to 6.1.1 but still we are getting the version error which stats that :-
{
"FAILED": {
"CRITICAL": [
{
"min_platform_version": {
"description": "Checks that if pip packages are installed, phantom version > CURRENT_MIN_PHANTOM_VERSION",
"expected": "Min Phantom version in app json is too low. Found: \"5.3.5\" but expected >= \"5.5.0\"",
"message": "TEST WAS EXPECTED TO FAIL, BUT PASSED",
"success": false,
"verbose": [
"TEST WAS EXPECTED TO FAIL, BUT PASSED"
]
}
}
],
"NONCRITICAL": []
}
@splunk-soar-connectors-admin Can you please help me with the above comment? Thanks!
@yash-metron Pipeline failures will be managed by us Kindly provide write access so that we can add standard dev check changes.
@mishalp-crest We have granted the write access.
@mishalp-crest Static Tests results for commit 30d1ce4ca40a861358837bb29759b9d826c44cf1 - https://drive.google.com/file/d/1_kp_SHOftVI9N-Q6oMtsn9f9adkm6Ytr/view?usp=drivesdk
@mishalp-crest Compile Tests results for commit 30d1ce4ca40a861358837bb29759b9d826c44cf1 - https://drive.google.com/file/d/12o7OlLSuNZ4t5ttTDtaxVlq9ffp4eMp0/view?usp=drivesdk
@mishalp-crest Can you please let me know if we need to make any change about the FOSSA passing? As I am not aware of such process.
@mishalp-crest Static Tests results for commit 2dc268bcc8433b7306639222513528c8125b4ddd - https://drive.google.com/file/d/12tchvc6HHx9ETXo4KMEjY4ZPjN1QTDz6/view?usp=drivesdk
@mishalp-crest Compile Tests results for commit 2dc268bcc8433b7306639222513528c8125b4ddd - https://drive.google.com/file/d/14Ht4bI6NJJS4lhAe2yWenr9a3g6CGxy1/view?usp=drivesdk
@mishalp-crest Can you please let me know if we need to make any change about the FOSSA passing? As I am not aware of such process.
@devang-metron I am working on it only will soon release the app
@mishalp-crest Static Tests results for commit 05ebc3539055f27b43d6171ba937d47a222e729a - https://drive.google.com/file/d/1OKqrdmIQlp3K5sFDfHMcWph8gWbqFd0q/view?usp=drivesdk
@yash-metron @devang-metron We have done some standard dev changes Let us know if you have doubt or concern
@mishalp-crest Compile Tests results for commit 05ebc3539055f27b43d6171ba937d47a222e729a - https://drive.google.com/file/d/1Aiqg1LjJ-bNPztqoPcdOwH8gtD7JvqTz/view?usp=drivesdk
@mishalp-crest Static Tests results for commit 54923a81dc7d136a5f96627f7dc2d292023b705c - https://drive.google.com/file/d/1vFoh6FWwvmchVwEVVWpgxlI2ysGj8XYu/view?usp=drivesdk
@mishalp-crest Compile Tests results for commit 54923a81dc7d136a5f96627f7dc2d292023b705c - https://drive.google.com/file/d/1qxYTx8JD1CNYqyexmq-_o2QmpRb2v8U9/view?usp=drivesdk
Hey @mishalp-crest, Just one doubt, app version and min phantom version are mismatching in Readme and manifest files. Is it fine? Thanks!
Hey @mishalp-crest, Just one doubt, app version and min phantom version are mismatching in Readme and manifest files. Is it fine? Thanks!
For readme it will be automatically managed What do you mean by manifest file?
@mishalp-crest by manifest, I mean digitalshadows.json file. Thanks for the info.
@mishalp-crest Static Tests results for commit fdeb52f22164c8b2a6a05ed9e10e4c7f0f6370d8 - https://drive.google.com/file/d/1GIUrwLRDGpwTvbG3LgIxp07TlzpLy2Q6/view?usp=drivesdk
@mishalp-crest Compile Tests results for commit fdeb52f22164c8b2a6a05ed9e10e4c7f0f6370d8 - https://drive.google.com/file/d/1z_IMiHgg1nfQFzux87iRub2HRpY-7pVR/view?usp=drivesdk
@mishalp-crest Static Tests results for commit b5e99efcb519b37ecac4531da0c2a23c7e4f1c04 - https://drive.google.com/file/d/1-WarXImTwlYi23qctDccQOUsD9VSArth/view?usp=drivesdk
@mishalp-crest Compile Tests results for commit b5e99efcb519b37ecac4531da0c2a23c7e4f1c04 - https://drive.google.com/file/d/18HNC6BTyEy3Tm_Cd0Uqd5tlWH87Gw4_t/view?usp=drivesdk
@yash-metron @devang-metron Do you want to keep a specific version of the certifi?
@mishalp-crest It should be fine. We will give one sanity though.
@mishalp-crest Static Tests results for commit db3845761e45685820900cfbc593999a9842755d - https://drive.google.com/file/d/1irFUUt1mNFjKXdQcGdFAWCVWbvdFctxj/view?usp=drivesdk
@mishalp-crest Compile Tests results for commit db3845761e45685820900cfbc593999a9842755d - https://drive.google.com/file/d/1AONcxNTucSksYadZ47iBLfVlzmKNcVWi/view?usp=drivesdk
@mishalp-crest Static Tests results for commit db3845761e45685820900cfbc593999a9842755d - https://drive.google.com/file/d/1BVGpPmc7qVrBAbOPgy4NWsURWmLPi-ob/view?usp=drivesdk
@mishalp-crest Static Tests results for commit fc9c154407256a17e338c1b299a1e0fda481aa40 - https://drive.google.com/file/d/1f_lEAUN37b739ZyELrY_jxXgXeCYOzF5/view?usp=drivesdk
@mishalp-crest Compile Tests results for commit fc9c154407256a17e338c1b299a1e0fda481aa40 - https://drive.google.com/file/d/1j7pomY_4WfU3PXkKzoyOnNDQ_SUHaIif/view?usp=drivesdk
@mishalp-crest Static Tests results for commit 47971c5abe19e99f32a4f36ad214bde06c942845 - https://drive.google.com/file/d/1szsXOLjWIQrHJSl8MKiV8DuvF5CN0EOx/view?usp=drivesdk
@mishalp-crest Compile Tests results for commit 47971c5abe19e99f32a4f36ad214bde06c942845 - https://drive.google.com/file/d/1PrvaLgiBi4GN1eNBqWNCGB2PnxgnO-8T/view?usp=drivesdk
Please ensure your pull request (PR) adheres to the following guidelines:
Pull Request Checklist
Please check if your PR fulfills the following requirements:
DigitalShadows: BugFix - Updated the "label", label which are present in the config
next
branch of the forked repo. Create separate feature branch for raising the PR.Pull Request Type
Please check the type of change your PR introduces:
Security Considerations (REQUIRED)
manual_readme_content.md
.manual_readme_content.md
all methods (eg, OAuth) used to authenticate with the service that the connector is integrating with.manual_readme_content.md
.nosemgrep
? If yes, please provide justification in an additional comment next to the ignored code.Release Notes (REQUIRED)
What is the current behavior? (OPTIONAL)
What is the new behavior? (OPTIONAL)
Other information (OPTIONAL)
Pay close attention to (OPTIONAL)
Screenshots (if relevant)
Thanks for contributing!