falconsandbox: bugfix - use vault_info() instead of get_file_path()

rbariatti commented 2 years ago

Please ensure your pull request (PR) adheres to the following guidelines:

Please refer to our contributing documentation for any questions on submitting a pull request, link: Contribution Guide

Pull Request Checklist

Please check if your PR fulfills the following requirements:

[x] Testing of all the changes has been performed (for bug fixes / features)
[x] The readme.html has been reviewed and added / updated if needed (for bug fixes / features)
[x] Use the following format for the PR description: <App Name>: <PR Type> - <PR Description>
[x] Provide release notes as part of the PR submission which describe high level points about the changes for the upcoming GA release.
[ ] Verify all checks are passing.
[x] Do NOT use the next branch of the forked repo. Create separate feature branch for raising the PR.
[x] Do NOT submit updates to dependencies unless it fixes an issue.
Pull Request Type

Please check the type of change your PR introduces:

[ ] New App
[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation
[ ] Other (please describe):

Security Considerations (REQUIRED)

[ ] If you are exposing any endpoints using a REST handler, please document them in the readme.html.
[ ] If this is a new connector or you are adding new actions
- [ ] Please document in the readme.html all methods (eg, OAuth) used to authenticate with the service that the connector is integrating with.
- [ ] If any actions are unable to run on SOAR Cloud, please document this in the readme.html.
[ ] Are you introducing any new cryptography modules? If yes, please elaborate their purpose:
[x] Are you are accessing the file system? If yes, please verify that you are only accessing paths returned through the Vault API.
[ ] Are you are marking code to be ignored by Semgrep with nosemgrep? If yes, please provide justification in an additional comment next to the ignored code.

Release Notes (REQUIRED)

The detonate_file action was failing due to the fact that an old Vault API was used. It was not successful in retrieving vault file's path based on their vault_id. The following deprecated calls:
```
[...]
try:
from phantom.vault import Vault
except:
import phantom.vault as Vault
[...]
Vault.get_file_path(vault_id)
Vault.get_vault_file(vault_id)
[...]
```
have been replaced with the actual Vault API (https://docs.splunk.com/Documentation/SOARonprem/5.3.1/PlaybookAPI/VaultAPI):
```
[...]
import phantom.rules as ph_rules
[...]
ph_rules.vault_info(container_id=container_id, vault_id=vault_id)
[...]
```
What is the current behavior? (OPTIONAL)
The app currently fails to retrieve path of vault files due to deprecated API usage. The detonate_file is therefore failing.

What is the new behavior? (OPTIONAL)

Using up to date vault API in order to retrieve vault files' path.

Other information (OPTIONAL)

Any other information that is important to this PR such as screenshots of how the component looks before and after the change.

Pay close attention to (OPTIONAL)

Any specific code change or test case points which must be addressed/reviewed at the time of GA release.

Screenshots (if relevant)

Thanks for contributing!

splunk-soar-connectors-bot commented 2 years ago

@rbariatti Static Tests results for commit 1aa4b69c3f4ec6e5a19415d5ae573327cb688810 - https://drive.google.com/file/d/1zFHCl1EqvDyBXXxL_8jy0IALIZVUtyPj/view?usp=drivesdk

splunk-soar-connectors-bot commented 2 years ago

@rbariatti Static Tests results for commit 396e76c32c9103a384ec69721351b2e726184d27 - https://drive.google.com/file/d/1fd-OX3Z0wR7on4UrsMefMryuQb4AWQqb/view?usp=drivesdk

splunk-soar-connectors-bot commented 2 years ago

@rbariatti Static Tests results for commit 413ed39066d67cfbf5ec824151f056df49c93f77 - https://drive.google.com/file/d/1IdxiEuWAvXp8wh-X8WuPu5b8taCZLSwV/view?usp=drivesdk

dgopani-crest commented 2 years ago

Hi @rbariatti, Can you please check Linting and Static Tests failures and fix those. Please let us know if you have any query in that.

rbariatti commented 2 years ago

Hi @rbariatti, Can you please check Linting and Static Tests failures and fix those. Please let us know if you have any query in that.

Hello @dgopani-crest, To be totally honest. I have only touch small portion of the code and all the linting and static test failure are not related to my changes. I made minor changes, just for the action to work. And I will not have time to review all those errors. Can you consider fixing those issues during merge process ?

Thank you for your understanding.

dgopani-crest commented 2 years ago

Hello @rbariatti, As discussed with our product manager @mattsayar-splunk, we will work on this app and release it with the submitted PR. Thanks!

rbariatti commented 2 years ago

@dgopani-crest, @mattsayar-splunk, what a good news. Thank you very much :)

splunk-soar-connectors-bot commented 2 years ago

@pdesai-crest Static Tests results for commit 876d95489cecc652cc61da577176f73064343cf6 - https://drive.google.com/file/d/19BbtqY4I-O1aBg1jf3BKCKJIx9Ea6oFv/view?usp=drivesdk

splunk-soar-connectors-bot commented 2 years ago

@pdesai-crest Static Tests results for commit 8e2aeb9b2a42c38bf8bc004386258bcfea487599 - https://drive.google.com/file/d/1qCeQve2D3gv6X6dc3uSSlndiVvQ3dFYT/view?usp=drivesdk

splunk-soar-connectors-bot commented 2 years ago

@pdesai-crest Static Tests results for commit b5e159c7581884babacf21e317f98d8d984fab24 - https://drive.google.com/file/d/1Xtr_ztZ8TILiOEy88KdFPUpF_t6bxJfR/view?usp=drivesdk

splunk-soar-connectors-bot commented 2 years ago

@pdesai-crest Static Tests results for commit 53118c8eb074798396dbbcc97431c0f8ac5826ce - https://drive.google.com/file/d/1wnvLJnGnJ40dXNigLyvgVNWnenZwyS6v/view?usp=drivesdk

splunk-soar-connectors-bot commented 2 years ago

@pdesai-crest Static Tests results for commit c2b6f9cb4f017e4b26dcc30cac20b69f2535553b - https://drive.google.com/file/d/1EwOc8rNoIU85VBci40G3VF74GVK3x2Ct/view?usp=drivesdk

splunk-soar-connectors-bot commented 2 years ago

@pdesai-crest Static Tests results for commit 4a6faece521002bb1af4e618a6da3a51b2331354 - https://drive.google.com/file/d/1JlY36g8f5Ojbq__QBGc7bbYl0BWMDHoH/view?usp=drivesdk

splunk-soar-connectors-bot commented 2 years ago

@pdesai-crest Static Tests results for commit 9cb6abd00d4271759e5b59e1b1878aa81dad7432 - https://drive.google.com/file/d/1Vxm37_Jxtg66SNSdecgHDHlu3LATafdJ/view?usp=drivesdk

joshquerinphantom commented 2 years ago

@pdesai-crest the static tests are failing. have you looked at them? It appears the GUIDs are not matching. I don't see anything obvious in the commits, but just to double-check.

splunk-soar-connectors-bot commented 2 years ago

@pdesai-crest Static Tests results for commit 9cb6abd00d4271759e5b59e1b1878aa81dad7432 - https://drive.google.com/file/d/1zkjwvw_ernDNyiiwWPzxlEgc9ufMHV7m/view?usp=drivesdk

splunk-soar-connectors / falconsandbox