Proofpoint: Bugfix - Fix two issues (#7, #8)

bneises commented 11 months ago

Please ensure your pull request (PR) adheres to the following guidelines:

Please refer to our contributing documentation for any questions on submitting a pull request, link: Contribution Guide

Pull Request Checklist

Please check if your PR fulfills the following requirements:

[X] Testing of all the changes has been performed (for bug fixes / features)
[ ] The manual_readme_content.md has been reviewed and added / updated if needed (for bug fixes / features)
[X] Use the following format for the PR description: <App Name>: <PR Type> - <PR Description>
[X] Provide release notes as part of the PR submission which describe high level points about the changes for the upcoming GA release.
[x] Verify all checks are passing.
[X] Do NOT use the next branch of the forked repo. Create separate feature branch for raising the PR.
[X] Do NOT submit updates to dependencies unless it fixes an issue.
Pull Request Type

Please check the type of change your PR introduces:

[ ] New App
[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation
[ ] Other (please describe):

Security Considerations (REQUIRED)

[X] If you are exposing any endpoints using a REST handler, please document them in the manual_readme_content.md.
[x] If this is a new connector or you are adding new actions
- [x] Please document in the manual_readme_content.md all methods (eg, OAuth) used to authenticate with the service that the connector is integrating with.
- [ ] If any actions are unable to run on SOAR Cloud, please document this in the manual_readme_content.md.
[X] Are you introducing any new cryptography modules? If yes, please elaborate their purpose:
[X] Are you are accessing the file system? If yes, please verify that you are only accessing paths returned through the Vault API.
[X] Are you are marking code to be ignored by Semgrep with nosemgrep? If yes, please provide justification in an additional comment next to the ignored code.

Release Notes (REQUIRED)

Bug fix in 'get forensic' and 'get campaign' actions.
Bug fix when parsing error from Proofpoint API response.

What is the current behavior? (OPTIONAL)

What is the new behavior? (OPTIONAL)

Other information (OPTIONAL)

Pay close attention to (OPTIONAL)

Screenshots (if relevant)

Thanks for contributing!

splunk-soar-connectors-bot commented 11 months ago

Thank you for your submission! We have a total of 21 PRs open right now, and we are working hard on all of them! We will take a look as soon as we can.

splunk-soar-connectors-bot commented 11 months ago

@bneises Static Tests results for commit c130dbd0e88ce16cdfcd731c557d91829c25a420 - https://drive.google.com/file/d/1yRUC6wndTC89oXg6VoboCVMehT_OAq6z/view?usp=drivesdk

splunk-soar-connectors-bot commented 11 months ago

@bneises Compile Tests results for commit c130dbd0e88ce16cdfcd731c557d91829c25a420 - https://drive.google.com/file/d/1OVmq3JtrIIZ0O0ZaQoe9lcu2_TF7mZ_J/view?usp=drivesdk

splunk-soar-connectors-bot commented 11 months ago

@bneises Static Tests results for commit ace061a404fd90d835b1eb42477d6308f11df576 - https://drive.google.com/file/d/1FSbi5cyKsr5I0qmTXVXjzZMIFzBNo153/view?usp=drivesdk

splunk-soar-connectors-bot commented 11 months ago

@bneises Compile Tests results for commit ace061a404fd90d835b1eb42477d6308f11df576 - https://drive.google.com/file/d/1SMVgiVB8N68k7ycBrY3TH-ml85yOxvPJ/view?usp=drivesdk

bneises commented 11 months ago

I am unable to access the prodsec-scans for details on the failure, but the failure in the static test is irrelevant to this app since the variable name it is flagging is for the API endpoints.

splunk-soar-connectors-bot commented 11 months ago

@mishalp-crest Static Tests results for commit 2aa1ff6eab8d47d3dd3e4dfd0f5437f45302192f - https://drive.google.com/file/d/18-DW0_-dFVUFBo4uQ6DoWcuOJUs5mZ9M/view?usp=drivesdk

splunk-soar-connectors-bot commented 11 months ago

@mishalp-crest Compile Tests results for commit 2aa1ff6eab8d47d3dd3e4dfd0f5437f45302192f - https://drive.google.com/file/d/1pohYvO2xJf2mUNSjDM-0QupGUKM-tJSu/view?usp=drivesdk

splunk-soar-connectors-bot commented 11 months ago

@mishalp-crest Static Tests results for commit 825ea2382b458c6c83e838fbf0d061e8ff1372e6 - https://drive.google.com/file/d/1po1r56A82IOQGOtiy5kf7qfF3QbOotNP/view?usp=drivesdk

splunk-soar-connectors-bot commented 11 months ago

@mishalp-crest Compile Tests results for commit 825ea2382b458c6c83e838fbf0d061e8ff1372e6 - https://drive.google.com/file/d/1Cjqabtj_GaqHAB0GQUweRGvDdloqndXB/view?usp=drivesdk

splunk-soar-connectors-bot commented 11 months ago

@mishalp-crest Static Tests results for commit 18e9e5ccb9173358f0e5d03f46ba4bcce82ff4e8 - https://drive.google.com/file/d/1lyAk6WYUjQD_iKa4QKM6M501fBFU5Wt1/view?usp=drivesdk

splunk-soar-connectors-bot commented 11 months ago

@mishalp-crest Compile Tests results for commit 18e9e5ccb9173358f0e5d03f46ba4bcce82ff4e8 - https://drive.google.com/file/d/1e8PS_Hs3FsiHEGmih5eReInXG1rrO2tj/view?usp=drivesdk

splunk-soar-connectors-bot commented 11 months ago

@mishalp-crest Static Tests results for commit cd2c0122f78e9ec967fdfa21880c8af977593d94 - https://drive.google.com/file/d/1SUScnNxO9FsmnnGMSzbd0wBytwsUeOSh/view?usp=drivesdk

splunk-soar-connectors-bot commented 11 months ago

@mishalp-crest Compile Tests results for commit cd2c0122f78e9ec967fdfa21880c8af977593d94 - https://drive.google.com/file/d/1Gap31FgnM7k_fb3q6D3x5SOlCSCDjoZU/view?usp=drivesdk

splunk-soar-connectors-bot commented 11 months ago

@mishalp-crest Static Tests results for commit 4f7189161e0313b038e541363cabe16c333d2491 - https://drive.google.com/file/d/1UskJQe6Pz8K82VSZfN7jg8xlRVdspHHJ/view?usp=drivesdk

splunk-soar-connectors-bot commented 11 months ago

@mishalp-crest Compile Tests results for commit 4f7189161e0313b038e541363cabe16c333d2491 - https://drive.google.com/file/d/1JvCpEzuJEE_ESZdJbIDjXgjGf4JqpFXN/view?usp=drivesdk

splunk-soar-connectors-bot commented 11 months ago

@mishalp-crest Static Tests results for commit 70c83a0ebadd030ffcd05cc6a31f83194315beda - https://drive.google.com/file/d/1JoGDVTn8jOtRooHKNL_2zaibJH9f14zI/view?usp=drivesdk

splunk-soar-connectors-bot commented 11 months ago

@mishalp-crest Compile Tests results for commit 70c83a0ebadd030ffcd05cc6a31f83194315beda - https://drive.google.com/file/d/1Bfoja-sqW7wMmeKI2OzxHreROPR18Sbq/view?usp=drivesdk

splunk-soar-connectors-bot commented 11 months ago

@mishalp-crest Static Tests results for commit ab4a34250d15d679f399cc6b4ea6cc36af9b9169 - https://drive.google.com/file/d/1TxqlCWTnLOKQSMi4qns2uFrzi6MuKVGG/view?usp=drivesdk

splunk-soar-connectors-bot commented 11 months ago

@mishalp-crest Compile Tests results for commit ab4a34250d15d679f399cc6b4ea6cc36af9b9169 - https://drive.google.com/file/d/1I3tkCH0gF6KCz0X66KoJmElH0g821AJK/view?usp=drivesdk

mishalp-crest commented 11 months ago

@bneises I have made some standard dev check changes Feel free to let me know if you have any doubts or concerns.

splunk-soar-connectors-bot commented 11 months ago

@mishalp-crest Static Tests results for commit 5f5a54cd7d93175a3da33c217a1d9c560f7fb42b - https://drive.google.com/file/d/10Bx4pIlpdeNe5ayCxZUngSgCWc6vvzCc/view?usp=drivesdk

splunk-soar-connectors-bot commented 11 months ago

@mishalp-crest Compile Tests results for commit 5f5a54cd7d93175a3da33c217a1d9c560f7fb42b - https://drive.google.com/file/d/1HeoKKvqrllItt35N-Xwy1yHulPBVgNvk/view?usp=drivesdk

splunk-soar-connectors-bot commented 11 months ago

@mishalp-crest Static Tests results for commit b3f78281cf6e1fdc9ff18dca89eab57afd6360a4 - https://drive.google.com/file/d/1pF9mQhEuBA8GTdNcQe3xBm3E4R7IACeS/view?usp=drivesdk

splunk-soar-connectors-bot commented 11 months ago

@mishalp-crest Compile Tests results for commit b3f78281cf6e1fdc9ff18dca89eab57afd6360a4 - https://drive.google.com/file/d/1YL2W8gSH9aEFS11jtdcdXxAE0otG5xt2/view?usp=drivesdk

splunk-soar-connectors-bot commented 11 months ago

@mishalp-crest Static Tests results for commit 5e69ce5c13996abaa1b5732ed906858586dde4c9 - https://drive.google.com/file/d/16mZvU91i1MU6ZcXfBKCi2OWigVUqz2H4/view?usp=drivesdk

splunk-soar-connectors-bot commented 11 months ago

@mishalp-crest Compile Tests results for commit 5e69ce5c13996abaa1b5732ed906858586dde4c9 - https://drive.google.com/file/d/1t53PQ95vznniruwyXRW0WFPI7rB2x8oq/view?usp=drivesdk

splunk-soar-connectors-bot commented 11 months ago

@mishalp-crest Static Tests results for commit 344302ebd95b16dc43de7644ab3feeb965f06e86 - https://drive.google.com/file/d/12iwdn-IiilVhnraz_i7m_Cov9IhA4A9P/view?usp=drivesdk

splunk-soar-connectors-bot commented 11 months ago

@mishalp-crest Compile Tests results for commit 344302ebd95b16dc43de7644ab3feeb965f06e86 - https://drive.google.com/file/d/1WGcNXRSqKxHKfzirP_LDn9aTTbkxaKEB/view?usp=drivesdk

splunk-soar-connectors-bot commented 11 months ago

@mishalp-crest Static Tests results for commit e8a0bb003a4731addcd9c0d63a7e763e5989edd8 - https://drive.google.com/file/d/1HRih4L26jTDvKVnTO_zFMxyl--dotKhm/view?usp=drivesdk

splunk-soar-connectors-bot commented 11 months ago

@mishalp-crest Compile Tests results for commit e8a0bb003a4731addcd9c0d63a7e763e5989edd8 - https://drive.google.com/file/d/1DpZyRu-QDLZ6yia6jPZfAkyT2sQwXSQd/view?usp=drivesdk

splunk-soar-connectors-bot commented 11 months ago

@mishalp-crest Static Tests results for commit cc63888e134507236891936e4ce036f7dca74bce - https://drive.google.com/file/d/1vMnY7YzavLxqT0fzpNB6Ldk36jH6gMhi/view?usp=drivesdk

splunk-soar-connectors-bot commented 11 months ago

@mishalp-crest Compile Tests results for commit cc63888e134507236891936e4ce036f7dca74bce - https://drive.google.com/file/d/1bXu0yX4ikrjrogxU0Y8mYL6fv_80Y5bf/view?usp=drivesdk

splunk-soar-connectors / proofpoint