Recorded Future for Splunk SOAR 4.3.3 - Bug fixes - Alert Polling

[JQvickWester]

Please ensure your pull request (PR) adheres to the following guidelines:

• Please refer to our contributing documentation for any questions on submitting a pull request, link: Contribution Guide

Pull Request Checklist

Please check if your PR fulfills the following requirements:

• [X] Testing of all the changes has been performed (for bug fixes / features)
• [X] The manual_readme_content.md has been reviewed and added / updated if needed (for bug fixes / features)
• [X] Use the following format for the PR description: <App Name>: <PR Type> - <PR Description>
• [X] Provide release notes as part of the PR submission which describe high level points about the changes for the upcoming GA release.
• [ ] Verify all checks are passing.
• [X] Do NOT use the next branch of the forked repo. Create separate feature branch for raising the PR.
• [X] Do NOT submit updates to dependencies unless it fixes an issue.

  Pull Request Type

Please check the type of change your PR introduces:

• [ ] New App
• [X] Bugfix
• [ ] Feature
• [ ] Code style update (formatting, renaming)
• [ ] Refactoring (no functional changes, no api changes)
• [ ] Documentation
• [ ] Other (please describe):

Security Considerations (REQUIRED)

• [ ] If you are exposing any endpoints using a REST handler, please document them in the manual_readme_content.md.
• [ ] If this is a new connector or you are adding new actions
  • [ ] Please document in the manual_readme_content.md all methods (eg, OAuth) used to authenticate with the service that the connector is integrating with.
  • [ ] If any actions are unable to run on SOAR Cloud, please document this in the manual_readme_content.md.
• [ ] Are you introducing any new cryptography modules? If yes, please elaborate their purpose:
• [ ] Are you are accessing the file system? If yes, please verify that you are only accessing paths returned through the Vault API.
• [ X ] Are you are marking code to be ignored by Semgrep with nosemgrep? If yes, please provide justification in an additional comment next to the ignored code.

Release Notes (REQUIRED)

Unreleased

• Changes to polling of alerts; now requires a comma separated list to pull in alerts.
• Fixing logic issue blocking the polling of alerts.
• Fixing issues with hardcoded path for Cloud, instead utilizing Vault class to access path.

What is the current behavior? (OPTIONAL)

• Describe the current behavior that you are modifying.

What is the new behavior? (OPTIONAL)

• Describe the behavior or changes that are being added by this PR.

Other information (OPTIONAL)

• Any other information that is important to this PR such as screenshots of how the component looks before and after the change.

Pay close attention to (OPTIONAL)

• Any specific code change or test case points which must be addressed/reviewed at the time of GA release.

Screenshots (if relevant)

---

Thanks for contributing!

[splunk-soar-connectors-bot]

Thank you for your submission! We have a total of 19 PRs open right now, and we are working hard on all of them! We will take a look as soon as we can.

[splunk-soar-connectors-bot]

@JQvickWester Static Tests results for commit 11c22ce20737abe9ad7c17b60260e139626b295f - https://drive.google.com/file/d/1ugFW-JuJwG6pnLemNmSxQ1qaBVKS61ui/view?usp=drivesdk

[splunk-soar-connectors-bot]

@JQvickWester Compile Tests results for commit 11c22ce20737abe9ad7c17b60260e139626b295f - https://drive.google.com/file/d/16YTMtWdwd7fXuAFfObBbF4RKSNFq89yn/view?usp=drivesdk

[splunk-soar-connectors-bot]

@JQvickWester Static Tests results for commit 9bf89b76bb9809c0fce3cd933723f4b44c2fadfe - https://drive.google.com/file/d/1N7kcqaGjttyY-KDcscj-QtN0LAP4NDHy/view?usp=drivesdk

[splunk-soar-connectors-bot]

@JQvickWester Compile Tests results for commit 9bf89b76bb9809c0fce3cd933723f4b44c2fadfe - https://drive.google.com/file/d/1Hzd-BVhq2uDFocfYltxS72q0p1ac93N6/view?usp=drivesdk

[splunk-soar-connectors-bot]

@JQvickWester Static Tests results for commit 5a13156992daa07b54df0d39d643ebbc0f1b1595 - https://drive.google.com/file/d/1QPbo999qjYV6TnfFAYPa1PbKY-KgPBe9/view?usp=drivesdk

[splunk-soar-connectors-bot]

@JQvickWester Compile Tests results for commit 5a13156992daa07b54df0d39d643ebbc0f1b1595 - https://drive.google.com/file/d/1P1_03ZBAIzJOioSojk511JXXeyThe3-p/view?usp=drivesdk

[splunk-soar-connectors-bot]

@JQvickWester Static Tests results for commit a8b7b33bd570189bc909331a17cd242b1fbf8a83 - https://drive.google.com/file/d/1cJSO0IzNI9bMj8u_EQKWYQiRcRXlZvlt/view?usp=drivesdk

[splunk-soar-connectors-bot]

@JQvickWester Static Tests results for commit d875613e8696ae622c873ae690fe8487cf8570c2 - https://drive.google.com/file/d/1QAEbKtG2-6Fo_dMubo7nQqJxXhSW3aMJ/view?usp=drivesdk

[splunk-soar-connectors-bot]

@JQvickWester Compile Tests results for commit d875613e8696ae622c873ae690fe8487cf8570c2 - https://drive.google.com/file/d/12H2xnlT8LF-jc29G-M9FOkbO5uvK6RsJ/view?usp=drivesdk

[splunk-soar-connectors-bot]

@JQvickWester Static Tests results for commit a9c66503a433d4f85131c7b526fab47e0290ec7b - https://drive.google.com/file/d/1TnaG4X2iwaviROw1tu-VjBdI0J9LdXX6/view?usp=drivesdk

[splunk-soar-connectors-bot]

@JQvickWester Compile Tests results for commit a9c66503a433d4f85131c7b526fab47e0290ec7b - https://drive.google.com/file/d/1f-sehQU-frwleQgnBAtfuhZvLetlf-Am/view?usp=drivesdk

[splunk-soar-connectors-bot]

@JQvickWester Static Tests results for commit a13adb6b6ff284719548456c26775fb3c41e3b1b - https://drive.google.com/file/d/1Ln2NSasEaTsXigg6bIYJ-O-oa3ptJNMH/view?usp=drivesdk

[splunk-soar-connectors-bot]

@JQvickWester Compile Tests results for commit a13adb6b6ff284719548456c26775fb3c41e3b1b - https://drive.google.com/file/d/1PPN4BFOyDyxjH6l-CEuxe06FdBaf6jPR/view?usp=drivesdk

[splunk-soar-connectors-bot]

@JQvickWester Static Tests results for commit 311bad10d6f3216b1060c67faeabb7e43bd98028 - https://drive.google.com/file/d/185iNrmFbibMwRXMafqDpyKajZ-XWXvmy/view?usp=drivesdk

[splunk-soar-connectors-bot]

@JQvickWester Compile Tests results for commit 311bad10d6f3216b1060c67faeabb7e43bd98028 - https://drive.google.com/file/d/1kwQ4lSWbqFRSKQmmZLWt9RPEpfSeY0Bv/view?usp=drivesdk

[splunk-soar-connectors-bot]

@JQvickWester Static Tests results for commit ea078b1eadbefcd42b3f4bafbcb8d2e38e82e6a0 - https://drive.google.com/file/d/1-Uxu0_lCEb_9pGFgXpuaM196DUFxn80h/view?usp=drivesdk

[splunk-soar-connectors-bot]

@JQvickWester Compile Tests results for commit ea078b1eadbefcd42b3f4bafbcb8d2e38e82e6a0 - https://drive.google.com/file/d/1SznFe9oBuqHdvpAAHF52X3fCwJ802xMw/view?usp=drivesdk

[splunk-soar-connectors-bot]

@JQvickWester Static Tests results for commit 2897bbf9a651184e384b7b8a19537e2bc77ee3c9 - https://drive.google.com/file/d/1eUR4yP6GcbX9p0BUjACz4GTkXU4OtAvQ/view?usp=drivesdk

[splunk-soar-connectors-bot]

@JQvickWester Compile Tests results for commit 2897bbf9a651184e384b7b8a19537e2bc77ee3c9 - https://drive.google.com/file/d/1pXINMDxzzN_Mr6LVb_5XxjEiOan7aSj1/view?usp=drivesdk

[splunk-soar-connectors-bot]

@mishalp-crest Static Tests results for commit 2a18d94fb30fb817a645f652c37ebab9b9144bff - https://drive.google.com/file/d/1jhc-QuNWaOY1Abpr9D8nuIcyDbLt0d8z/view?usp=drivesdk

[splunk-soar-connectors-bot]

@mishalp-crest Compile Tests results for commit 2a18d94fb30fb817a645f652c37ebab9b9144bff - https://drive.google.com/file/d/1Z33NETvzoAD8QKLm8v04wMq22INLqobo/view?usp=drivesdk

[mishalp-crest]

@JQvickWester
We usually update the app's minor version when there is a bug fix. Let us know if you want to update it.

[splunk-soar-connectors-bot]

@mishalp-crest Static Tests results for commit c79e4feee6b81c4765505afc48066ab60b024393 - https://drive.google.com/file/d/1zUsYjQXnRn9idb2W5Jz9hX06QBxVQ5MC/view?usp=drivesdk

[splunk-soar-connectors-bot]

@mishalp-crest Compile Tests results for commit c79e4feee6b81c4765505afc48066ab60b024393 - https://drive.google.com/file/d/1FyA9k46531sSBYxSQFEHwcX_kEtNHj-_/view?usp=drivesdk

[mishalp-crest]

@JQvickWester Can you please confirm?

[nplebanskyi]

Hello @mishalp-crest, I'm colleague of @JQvickWester, he's currently on long vacation. Why did you change the publisher from Recorded Future, Inc to Splunk in this commit? And also why did you decrease the min_phantom_version in the same commit?

[splunk-soar-connectors-bot]

@mishalp-crest Static Tests results for commit eb812c58a54103a3d5ca9a217af028140a80e179 - https://drive.google.com/file/d/1bhwfAqUWUCRUSSdxM9xGHPgC91zP-EcW/view?usp=drivesdk

[splunk-soar-connectors-bot]

@mishalp-crest Static Tests results for commit a4dc68e121dc35b0aa8c18e5b2bb7d1449539f92 - https://drive.google.com/file/d/1KwKNOyGxG2u2M_J3LaYd14pKLv0HUYFE/view?usp=drivesdk

[mishalp-crest]

Hello @mishalp-crest, I'm colleague of @JQvickWester, he's currently on long vacation. Why did you change the publisher from Recorded Future, Inc to Splunk in this commit? And also why did you decrease the min_phantom_version in the same commit?

Reverted those changes

[splunk-soar-connectors-bot]

@mishalp-crest Compile Tests results for commit a4dc68e121dc35b0aa8c18e5b2bb7d1449539f92 - https://drive.google.com/file/d/10TOjppRYbysBTrpDRUdm1Ses6LJekTYK/view?usp=drivesdk

[nplebanskyi]

@mishalp-crest could you please apply my suggestions for version and also revert the changes to min_phantom_version again? It should be 6.2.1 and not 6.1.1. Thank you!

[splunk-soar-connectors-bot]

@mishalp-crest Static Tests results for commit 4a5d19fe910b5efbebaa10d5e4785f5941327135 - https://drive.google.com/file/d/1mn6TTpvS41tdAbrvs2PCDY9QIIWcy16u/view?usp=drivesdk

[splunk-soar-connectors-bot]

@mishalp-crest Compile Tests results for commit 4a5d19fe910b5efbebaa10d5e4785f5941327135 - https://drive.google.com/file/d/195CfJu9KKbfTngVJ6hfY0bUTQqusxKPQ/view?usp=drivesdk

[mishalp-crest]

@nplebanskyi Done with the changes let us know if you have any concern / doubt

[nplebanskyi]

@mishalp-crest all looks good, thank you.