splunk-soar-connectors / recordedfuture

Apache License 2.0
4 stars 6 forks source link

Recorded future: Feature - New actions connected to RF APIs #8

Closed nestoor22 closed 1 year ago

nestoor22 commented 1 year ago

Please ensure your pull request (PR) adheres to the following guidelines:

Pull Request Checklist

Please check if your PR fulfills the following requirements:

Please check the type of change your PR introduces:

Security Considerations (REQUIRED)

Release Notes (REQUIRED)

What is the current behavior? (OPTIONAL)

What is the new behavior? (OPTIONAL)

Other information (OPTIONAL)

Pay close attention to (OPTIONAL)

Screenshots (if relevant)


Thanks for contributing!

splunk-soar-connectors-bot commented 1 year ago

Thank you for your submission! We have a total of 16 PRs open right now, and we are working hard on all of them! We will take a look as soon as we can.

splunk-soar-connectors-bot commented 1 year ago

@nestoor22 Static Tests results for commit 1b4ad48bf86726257743a9db565fc42a922268d1 - https://drive.google.com/file/d/1zzz-pxPYwOAdjB5vWXSjwT2CRtDkztGT/view?usp=drivesdk

splunk-soar-connectors-bot commented 1 year ago

@nestoor22 Compile Tests results for commit 1b4ad48bf86726257743a9db565fc42a922268d1 - https://drive.google.com/file/d/1kYFDYdbtPN0aN27AHT-1lJ5qORm367zw/view?usp=drivesdk

splunk-soar-connectors-bot commented 1 year ago

@nestoor22 Static Tests results for commit 7547a11dbe5fc504cc13d787a729c852d41b26bd - https://drive.google.com/file/d/1c9NJdsObqfPuoV_b7NIfELg1IakRYRPy/view?usp=drivesdk

splunk-soar-connectors-bot commented 1 year ago

@nestoor22 Compile Tests results for commit 7547a11dbe5fc504cc13d787a729c852d41b26bd - https://drive.google.com/file/d/1e7gnyktj3TayE4BCjN9Fej1K4WvLtY0p/view?usp=drivesdk

splunk-soar-connectors-bot commented 1 year ago

@nestoor22 Static Tests results for commit 060aad925f6fc259cf29e6691d24142bea48a6f3 - https://drive.google.com/file/d/18zyRj5k8kR1NjkADtRHSQ7koKPe8V-OI/view?usp=drivesdk

splunk-soar-connectors-bot commented 1 year ago

@nestoor22 Compile Tests results for commit 060aad925f6fc259cf29e6691d24142bea48a6f3 - https://drive.google.com/file/d/1pYBO_iHN35omoiuHYZoBmYd8gzJ-oXRg/view?usp=drivesdk

splunk-soar-connectors-bot commented 1 year ago

@nestoor22 Static Tests results for commit 9a475aae81d555551733e8e8ea6a3fe4d248e133 - https://drive.google.com/file/d/1UO37gsQfOL4NFccFbyu1Oh-550SNZ1_j/view?usp=drivesdk

splunk-soar-connectors-bot commented 1 year ago

@nestoor22 Compile Tests results for commit 9a475aae81d555551733e8e8ea6a3fe4d248e133 - https://drive.google.com/file/d/1vG3Jb_KZr_QI1ZagvewlIaBClROf-5OK/view?usp=drivesdk

splunk-soar-connectors-bot commented 1 year ago

@dhwanis-crest Static Tests results for commit 452d27580dd52269499d4e96fdef6e5683f7e4df - https://drive.google.com/file/d/1tUZPw_lfmq75OOHxrZrpqojzp_vghQWi/view?usp=drivesdk

splunk-soar-connectors-bot commented 1 year ago

@dhwanis-crest Compile Tests results for commit 452d27580dd52269499d4e96fdef6e5683f7e4df - https://drive.google.com/file/d/1uRgEr0QcLLO_W8-F4SrJ5RvV3JeV5665/view?usp=drivesdk

splunk-soar-connectors-bot commented 1 year ago

@dhwanis-crest Static Tests results for commit 5eea6e8118daa591718982a8af8bb7a2be015357 - https://drive.google.com/file/d/1yVLqHw_KFu28isk5b9QHhCqslPbJBRUG/view?usp=drivesdk

splunk-soar-connectors-bot commented 1 year ago

@dhwanis-crest Compile Tests results for commit 5eea6e8118daa591718982a8af8bb7a2be015357 - https://drive.google.com/file/d/1iLW3WzEDT0oAMiF1zaZFBk5RAwthqnxP/view?usp=drivesdk

dhwanis-crest commented 1 year ago

Hi @nestoor22, We are changing the min_phantom_version to 5.5.0. Is it fine for you?

dhwanis-crest commented 1 year ago

Hi @nestoor22, We have fixed the pipeline failures and all the pipelines are passing now. As this app is partner supported, we will not be merging this MR. Please proceed with the release activity from your end.

nestoor22 commented 1 year ago

Hi @nestoor22, We are changing the min_phantom_version to 5.5.0. Is it fine for you?

Hi! Yes, it is fine

dhwanis-crest commented 1 year ago

Hi @nestoor22, as mentioned above, this app is partner supported. So, we are not going to Merge this PR. If you are not from Recorded Future team, you can contact "support@recordedfuture.com" to get your PR merged and perform release activites.

nestoor22 commented 1 year ago

Hi @nestoor22, as mentioned above, this app is partner supported. So, we are not going to Merge this PR. If you are not from Recorded Future team, you can contact "support@recordedfuture.com" to get your PR merged and perform release activites.

Hi! I'm from the Recorded Future team, we are currently waiting a little bit. What is the next step for release? Should I merge this PR by myself when we are ready?

nestoor22 commented 1 year ago

Hi @dhwanis-crest ! We are ready to release, let me know if I can merge this PR

dhwanis-crest commented 1 year ago

Hi @nestoor22, Nothing pending from our end too. If you have the rights, you are feel free to merge this.

nestoor22 commented 1 year ago

Hi @nestoor22, Nothing pending from our end too. If you have the rights, you are feel free to merge this.

@dhwanis-crest I have no write access in the repository to merge it, could you help?

nestoor22 commented 1 year ago

Hi @dhwanis-crest ! Any updates about write access?

dhwanis-crest commented 1 year ago

Hi @nastorSplunk, Can you please guide @nestoor22 for the release activity. Also, provide them with the merge rights as this app is partner-supported.

nastorSplunk commented 1 year ago

Following up with Michael DiBella to verify access.

nastorSplunk commented 1 year ago

@nestoor22, I updated your perms. Let me know if that works

nestoor22 commented 1 year ago

@nestoor22, I updated your perms. Let me know if that works

@nastorSplunk Yes, I have "write" permissions. I'm going to merge it if nothing blocking from your side