ZeroFox: Bugfix - Fix version Consistency

DNRRomero commented 5 months ago

Please ensure your pull request (PR) adheres to the following guidelines:

Please refer to our contributing documentation for any questions on submitting a pull request, link: Contribution Guide

Pull Request Checklist

Please check if your PR fulfills the following requirements:

[x] Testing of all the changes has been performed (for bug fixes / features)
[x] The manual_readme_content.md has been reviewed and added / updated if needed (for bug fixes / features)
[x] Use the following format for the PR description: <App Name>: <PR Type> - <PR Description>
[ ] Provide release notes as part of the PR submission which describe high level points about the changes for the upcoming GA release.
[ ] Verify all checks are passing.
[x] Do NOT use the next branch of the forked repo. Create separate feature branch for raising the PR.
[x] Do NOT submit updates to dependencies unless it fixes an issue.
Pull Request Type

Please check the type of change your PR introduces:

[ ] New App
[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation
[x] Other (please describe):

Security Considerations (REQUIRED)

[ ] If you are exposing any endpoints using a REST handler, please document them in the manual_readme_content.md.
[ ] If this is a new connector or you are adding new actions
- [ ] Please document in the manual_readme_content.md all methods (eg, OAuth) used to authenticate with the service that the connector is integrating with.
- [ ] If any actions are unable to run on SOAR Cloud, please document this in the manual_readme_content.md.
[ ] Are you introducing any new cryptography modules? If yes, please elaborate their purpose:
[ ] Are you are accessing the file system? If yes, please verify that you are only accessing paths returned through the Vault API.
[ ] Are you are marking code to be ignored by Semgrep with nosemgrep? If yes, please provide justification in an additional comment next to the ignored code.

Release Notes (REQUIRED)

Provide release notes as part of the PR submission which describe high level points about the changes for the upcoming GA release.

What is the current behavior? (OPTIONAL)

Describe the current behavior that you are modifying.

What is the new behavior? (OPTIONAL)

Describe the behavior or changes that are being added by this PR.

Other information (OPTIONAL)

Any other information that is important to this PR such as screenshots of how the component looks before and after the change.

Pay close attention to (OPTIONAL)

Any specific code change or test case points which must be addressed/reviewed at the time of GA release.

Screenshots (if relevant)

Thanks for contributing!

splunk-soar-connectors-bot commented 5 months ago

Thank you for your submission! We have a total of 18 PRs open right now, and we are working hard on all of them! We will take a look as soon as we can.

splunk-soar-connectors-bot commented 5 months ago

@DNRRomero Static Tests results for commit 914023b5788164a086222e82872e32b6d6f1ae61 - https://drive.google.com/file/d/1WTAsMSYVYmX6wEKVq7M5iAs24PLDBkuW/view?usp=drivesdk

splunk-soar-connectors-bot commented 5 months ago

@DNRRomero Compile Tests results for commit 914023b5788164a086222e82872e32b6d6f1ae61 - https://drive.google.com/file/d/1P_w4L8m3UtAdWxlvW9naOGHYYYWzYawC/view?usp=drivesdk

splunk-soar-connectors-bot commented 5 months ago

@DNRRomero Static Tests results for commit 778c7e379d55b96f7b96b6cdb094e84d20614046 - https://drive.google.com/file/d/1QBTnDSYKfNAiJme21ctnlnRnhT2WE-kN/view?usp=drivesdk

splunk-soar-connectors-bot commented 5 months ago

@DNRRomero Compile Tests results for commit 778c7e379d55b96f7b96b6cdb094e84d20614046 - https://drive.google.com/file/d/1rjaqj-cfH7KV7pihxc_T8KCwpPaManKe/view?usp=drivesdk

splunk-soar-connectors-bot commented 5 months ago

@DNRRomero Static Tests results for commit 914023b5788164a086222e82872e32b6d6f1ae61 - https://drive.google.com/file/d/1epFNdXBpg_Nv9O_8veIcWKOSc9XB6vSJ/view?usp=drivesdk

splunk-soar-connectors-bot commented 5 months ago

@DNRRomero Compile Tests results for commit 914023b5788164a086222e82872e32b6d6f1ae61 - https://drive.google.com/file/d/1vIBjDud5zBK0kSfMlWY-IqPBvP3rlbq-/view?usp=drivesdk

splunk-soar-connectors-bot commented 5 months ago

@DNRRomero Static Tests results for commit 8d83cab3ccdff07bf5460f495a413cba0322dafc - https://drive.google.com/file/d/1LErqYdrDglatBgGJ2loLZ6sySqnVT1l1/view?usp=drivesdk

splunk-soar-connectors-bot commented 5 months ago

@DNRRomero Compile Tests results for commit 8d83cab3ccdff07bf5460f495a413cba0322dafc - https://drive.google.com/file/d/1oU-5Oh-bWCtUDdOBVXHXTLdVn0Wlf7D1/view?usp=drivesdk

splunk-soar-connectors-bot commented 5 months ago

@DNRRomero Static Tests results for commit a7a2c66efb2a809d8bc8e0433137b0d9b84a66db - https://drive.google.com/file/d/1FnTeJyOyyyCWxa44khT48yNXZTdEIsPc/view?usp=drivesdk

splunk-soar-connectors-bot commented 5 months ago

@DNRRomero Compile Tests results for commit a7a2c66efb2a809d8bc8e0433137b0d9b84a66db - https://drive.google.com/file/d/1bJ0ibruFecYUnPSxzkYHzB6KufLor8Vd/view?usp=drivesdk

spopat-crest commented 4 months ago

Hello @DNRRomero, Updating the app version from 1.0.1 to 3.5.1 (without other changes) will confuse the existing customers as all the versions in between are missing.

App version has 3 parts: <_major_version_>.<_minor_version_>.<_build_version_>

Build version update: In case of some minor fixes(which includes but not limited to document update, typos, library update)
Minor version update: In case of bugfixes
Major version update: In case of some major changes (which includes but not limited to backward compatiblity break, API update, addition of major functionalities not currently supported by app)

As a best practice we would recommend not to upgrade app version.

cc: @nastorSplunk @junlinl-splunk @ishans-crest

DNRRomero commented 4 months ago

Hi @spopat-crest The reason for the version-update change is that there is an existing manually distributed version of this app that has version 3.5.0, and customers are already confused about the Splunkbase app being 1.0.1. There are no customers that we are aware of that are using the Splunkbase version of our app because of this, we have discussed this as well with Splunk SOAR's PM

spopat-crest commented 4 months ago

Thanks @DNRRomero We will proceed with version change.

mishalp-crest commented 4 months ago

@DNRRomero Can you update the release notes and give me write access?

splunk-soar-connectors-bot commented 4 months ago

@DNRRomero Static Tests results for commit ea1067c92d7b69529786a35bea21c4091c3d7c46 - https://drive.google.com/file/d/13fwHBgfUPnLU04VcKkRUwVr4JpRJ4dED/view?usp=drivesdk

splunk-soar-connectors-bot commented 4 months ago

@DNRRomero Compile Tests results for commit ea1067c92d7b69529786a35bea21c4091c3d7c46 - https://drive.google.com/file/d/1LiSHtj85kcBmEH3JPhoHCq525R5dksNs/view?usp=drivesdk

DNRRomero commented 4 months ago

Hi @mishalp-crest I've just updated the release notes. Regarding write access, do you mean write access in our forked repository? Why is that required?

mishalp-crest commented 4 months ago

@DNRRomero Yes, to do cosmetic standard dev check changes if needed kindly add the note in unreleased.md

Also as per my observation, the expectation from your side is to delete the 1.0.1 version so if that is the case let us know

splunk-soar-connectors-bot commented 4 months ago

@DNRRomero Static Tests results for commit a898f1b33e1c3912ccada524bd2d776a94282235 - https://drive.google.com/file/d/1T56yBPmMFV4Mg61wkevN_PSUjS3DNEAl/view?usp=drivesdk

splunk-soar-connectors-bot commented 4 months ago

@DNRRomero Compile Tests results for commit a898f1b33e1c3912ccada524bd2d776a94282235 - https://drive.google.com/file/d/1_ueQCQf56SRpgZ0CLS8ybgCXvQcLYEyh/view?usp=drivesdk

DNRRomero commented 4 months ago

Hi @mishalp-crest moved release notes to unreleased, also gave you write access

DNRRomero commented 4 months ago

Also @mishalp-crest yes, the only 3.5.1 version should show up in splunkbase

splunk-soar-connectors-bot commented 4 months ago

@mishalp-crest Static Tests results for commit d65d3ed22bc498e65ef3889ea7753d1d8409ea8a - https://drive.google.com/file/d/1PWlvNEAQpWCN1qkVoqhP6uz7ugj6W7sO/view?usp=drivesdk

splunk-soar-connectors-bot commented 4 months ago

@mishalp-crest Compile Tests results for commit d65d3ed22bc498e65ef3889ea7753d1d8409ea8a - https://drive.google.com/file/d/1p-Gzfe1opnaeogD951CFgXuapAxlPut1/view?usp=drivesdk

mishalp-crest commented 4 months ago

@DNRRomero I have made some changes let me know if you have any concerns

DNRRomero commented 4 months ago

@mishalp-crest, looks good to me

DNRRomero commented 4 months ago

Hi @mishalp-crest is there anything left you'd like to change? is there an estimate time between PR merge and the update showing in splunkbase?

mishalp-crest commented 4 months ago

Hi @mishalp-crest is there anything left you'd like to change? is there an estimate time between PR merge and the update showing in splunkbase?

No, we are good. After merging into the main it will be reflected on Splunkbase We have to raise the request to remove the older version externally

It should get merged in main in 1 - 2 days Not sure about the external request

splunk-soar-connectors / zerofoxalerts