pin to requests 2.31 to resolve docker library error

splunk / contentctl

Splunk Content Control Tool

Apache License 2.0

82 stars 21 forks source link

pin to requests 2.31 to resolve docker library error #150

Closed pyth0n1c closed 3 months ago

pyth0n1c commented 4 months ago

This morning, python requests library 2.32 was pushed. However, this breaks docker-py: https://github.com/docker/docker-py/issues/3256

Since docker-py is a dependency, we must pin to request ~2.31 for now

We also have added setuptools, which is not installed by default in Python 3.12: Link to Python 3.12 release notes To pyproject.toml since it is used in pycvesearch: https://github.com/cve-search/PyCVESearch/blob/6a492a72f95ea96f1ef56109d138dfa344d7e9ec/pycvesearch/core.py#L4

ljstella commented 3 months ago

requests 2.32.0 and 2.32.1 were both yanked with 2.32.2 being the new release. However, I believe we actually need docker-py's next release which includes a more stable fix. That release appears to be in-progress (https://github.com/docker/docker-py/pull/3262) but is not yet available.

patel-bhavin commented 3 months ago

Merging this query and then will create another PR when a more stable fix is out!