search

splunk / contentctl

Splunk Content Control Tool
Apache License 2.0
93 stars 25 forks source link

initial pass at resolving ruff issues #289

Closed pyth0n1c closed 2 months ago

pyth0n1c commented 2 months ago

Tons of changes, many of them small (like resolving unused imports or variables) but great code cleanup. This effort is motivated by the following PR to add ruff support in CI/CD: https://github.com/splunk/contentctl/pull/254

However, because there are so many changes, maybe they should be made after the PR backlog has been cleared out?

This does not begin to address formatting issues, just things like bad imports, unused variables, etc.

ljstella commented 2 months ago

I would agree- clearing the PR backlog first will make this easier so we won't have to spend even more time potentially clearing conflicts in every open PR.

I am open to doing this in two stages where we enforce the linter first and then fast-follow w/ the formatter if that means getting the first one of these changes (this one) in faster.

pyth0n1c commented 2 months ago

I would agree- clearing the PR backlog first will make this easier so we won't have to spend even more time potentially clearing conflicts in every open PR.

I am open to doing this in two stages where we enforce the linter first and then fast-follow w/ the formatter if that means getting the first one of these changes (this one) in faster.

I agree. The takeaway is that this PR only took maybe 30 minutes to throw together, so the initial pass of changes will be pretty easier! Easier than keeping this PR up to date as we merge changes. I am closing this out - we will reopen a PR later with all the changes rather than continuously update this one.