Open Res260 opened 1 week ago
I will merge with main to make sure nothing breaks with the latest changes on main.
I will merge with main to make sure nothing breaks with the latest changes on main.
Thank you, this is great and very helpful. I will deprecate that other PR and take a look at this one!
I merged with main, ran my manual tests, everything is working fine on my end!
This is basically all the changes our private fork have at the moment.
Here is what it includes:
contentctl test
:wait_for_app_installation
. This step ensures that the required apps are correctly installed AND configured (for splunk ES)contentctl test
to ensure Docker has the time to map the ports correctly before contentctl attempts to connect. This was problematic on Windows with WSL.contentctl validate
andcontentctl build
needed the splunkbase creds to work, which made no sense.print()
statementscontentctl test
now creates missing indexes specified in test data ascustom_index
Fixes #319 Fixes #295 Fixes #321
@pyth0n1c So sorry to open a new PR, but this was the only way for me to contribute without having to send patch files like a caveman. We should close #322 and use this PR as well. It includes a lot of changes, but I think they are all changes worthy to be included upstream and fixes weird bugs regarding using
contentctl test
on Windows and downloading apps from SplunkBase.