search

splunk / corona_virus

This project includes an app that allows users to visualize and analyze information about COVID-19 using data made publicly-available by Johns Hopkins University. For more information on legal disclaimers, please see the README.
Apache License 2.0
77 stars 35 forks source link

messages flooding console #24

Open glimpsedchaos opened 4 years ago

glimpsedchaos commented 4 years ago

Describe the bug Viewing covid-19 or other dashboards on https://covid-19.splunkforgood.com/dashboard_hub floods messages to the console, repeating with each autoupdate.js call this increasing memory usage in the browser.

To Reproduce Steps to reproduce the behavior:

  1. Go to 'Open dashboard, such as covid-19'
  2. Open whatever development tool in browser
  3. Check the console output
  4. See messages like the following:

main.d14d1855.chunk.js:1 Current version is 92b13f7 16:21:50.411 11.0380a9aa.chunk.js:2 Failed to calculate layout scale: containerWidth= 0 , width= 1800 ; falling back to scale=1 l.warn @ 11.0380a9aa.chunk.js:2 16:21:50.909 static/js/1.2d69059b.chunk.js:2 The option type 'string' for 'seriesColors' has been deprecated. l.warn @ static/js/1.2d69059b.chunk.js:2 16:21:50.909 static/js/1.2d69059b.chunk.js:2 The option type 'string' for 'data.fieldShowList' has been deprecated. l.warn @ static/js/1.2d69059b.chunk.js:2 16:21:50.909 static/js/1.2d69059b.chunk.js:2 The option type 'string' for 'data.fieldHideList' has been deprecated. l.warn @ static/js/1.2d69059b.chunk.js:2 16:21:50.909 static/js/1.2d69059b.chunk.js:2 The option type 'string' for 'legend.labels' has been deprecated. l.warn @ static/js/1.2d69059b.chunk.js:2 16:21:50.909 static/js/1.2d69059b.chunk.js:2 The option type 'string' for 'fieldColors' has been deprecated. l.warn @ static/js/1.2d69059b.chunk.js:2 16:21:51.686 static/js/1.2d69059b.chunk.js:2 The option type 'string' for 'seriesColors' has been deprecated. l.warn @ static/js/1.2d69059b.chunk.js:2 16:21:51.686 static/js/1.2d69059b.chunk.js:2 The option type 'string' for 'fieldColors' has been deprecated. l.warn @ static/js/1.2d69059b.chunk.js:2 16:21:52.400 static/js/19.28086849.chunk.js:2 Theme property "LEGEND_FONT_COLOR" not available in default theme 16:21:52.400 static/js/19.28086849.chunk.js:2 Theme property "LEGEND_UNHIGHLIGHT_COLOR" not available in default theme 16:21:52.424 static/js/19.28086849.chunk.js:2 drawing a chart with dimensions: Object 16:21:52.424 static/js/19.28086849.chunk.js:2 drawing a chart with properties: Object 16:21:52.425 static/js/19.28086849.chunk.js:2 drawing a chart with data: Object 16:21:52.440 static/js/19.28086849.chunk.js:2 Theme property "AXIS_LABELS_FONT_COLOR" not available in default theme 16:21:52.440 static/js/19.28086849.chunk.js:2 Theme property "AXIS_TITLE_FONT_COLOR" not available in default theme 16:21:52.440 static/js/19.28086849.chunk.js:2 Theme property "AXIS_GRID_LINE_COLOR" not available in default theme 16:21:52.442 static/js/19.28086849.chunk.js:2 Theme property "AXIS_LABELS_FONT_COLOR" not available in default theme 16:21:52.442 static/js/19.28086849.chunk.js:2 Theme property "AXIS_TITLE_FONT_COLOR" not available in default theme 16:21:52.442 static/js/19.28086849.chunk.js:2 Theme property "AXIS_GRID_LINE_COLOR" not available in default theme 16:21:52.454 static/js/19.28086849.chunk.js:2 config object to be sent to highcharts: Object 16:21:53.033 static/js/19.28086849.chunk.js:2 Theme property "LEGEND_FONT_COLOR" not available in default theme 16:21:53.033 static/js/19.28086849.chunk.js:2 Theme property "LEGEND_UNHIGHLIGHT_COLOR" not available in default theme 16:21:53.109 static/js/19.28086849.chunk.js:2 drawing a chart with dimensions: Object 16:21:53.109 static/js/19.28086849.chunk.js:2 drawing a chart with properties: Object 16:21:53.110 static/js/19.28086849.chunk.js:2 drawing a chart with data: Object 16:21:53.113 static/js/19.28086849.chunk.js:2 Theme property "AXIS_LABELS_FONT_COLOR" not available in default theme 16:21:53.113 static/js/19.28086849.chunk.js:2 Theme property "AXIS_TITLE_FONT_COLOR" not available in default theme 16:21:53.113 static/js/19.28086849.chunk.js:2 Theme property "AXIS_GRID_LINE_COLOR" not available in default theme 16:21:53.113 static/js/19.28086849.chunk.js:2 Theme property "AXIS_LABELS_FONT_COLOR" not available in default theme 16:21:53.113 static/js/19.28086849.chunk.js:2 Theme property "AXIS_TITLE_FONT_COLOR" not available in default theme 16:21:53.113 static/js/19.28086849.chunk.js:2 Theme property "AXIS_GRID_LINE_COLOR" not available in default theme 16:21:53.125 static/js/19.28086849.chunk.js:2 config object to be sent to highcharts: Object

Expected behavior Minimal console logging.

Desktop (please complete the following information):

ryanwoconnor commented 4 years ago

Noting this. Is this specifically related to our public dashboards though? Just want to make sure there is nothing to fix in this repository.

Also can you let me know specifically which page you see this on? It does not happen on the two tested:

  1. https://covid-19.splunkforgood.com/coronavirus__covid_19_
  2. https://covid-19.splunkforgood.com/dashboard_hub
glimpsedchaos commented 4 years ago

Ryan,

Just the public dashboards that I am aware of.

I have timestamps turned on in my Chrome Developer Tools, just fyi.

  1. https://covid-19.splunkforgood.com/coronavirus__covid_19_

I see it in the dashboards using Chrome Version 80.0.3987.149 (Official Build) (64-bit). Also in Firefox. I had someone else check as they shared their screen with the same results using Chrome.

but also in: https://covid-19.splunkforgood.com/covid_19_detailed (755 messages after it loads up) https://covid-19.splunkforgood.com/timelapse (fastly growing to over 2,000 messages until I closed) https://covid-19.splunkforgood.com/covid_19_uk (55 messages) https://covid-19.splunkforgood.com/nyc_dashboard (136 messages) https://covid-19.splunkforgood.com/us_hotspots_detailed (767 messages) https://covid-19.splunkforgood.com/covid_19_cuba (88 messages) https://covid-19.splunkforgood.com/covid_19_datasource_comparison (47 messages)

  1. https://covid-19.splunkforgood.com/dashboard_hub (This is all I see in my console:)

17:17:17.881 autoupdate.js:5 Current version is 92b13f7 17:17:18.152 console.js:9 Failed to calculate layout scale: containerWidth= 0 , width= 1500 ; falling back to scale=1

glimpsedchaos commented 4 years ago

I also checked on another PC, newer version of Chrome, different ISP with the same results.

I think this is because there is quite a bit of logger.debug entries (from index.js):

function setTheme(themeKey) { if (!_constants.THEMES[themeKey]) { logger.debug('Theme "' + themeKey + '" not available - falling back to default'); currentThemeKey = 'default'; } else { currentThemeKey = themeKey; } currentTheme = _constants.THEMES[currentThemeKey]; }

function getThemeProperty(propertyName) { if (!currentTheme[propertyName]) { logger.debug('Theme property "' + propertyName + '" not available in ' + currentThemeKey + ' theme'); return undefined; } return currentTheme[propertyName]; }

handleDraw: function handleDraw(callback) {
    logger.debug('drawing a chart with dimensions:', {
        width: this.width,
        height: this.height
    });
    logger.debug('drawing a chart with properties:', this.properties);
    logger.debug('drawing a chart with data:', this.dataSet.toJSON());
    this.benchmark('Draw Started');
    this.applyColorPalette();
    // if there is already a draw in progress, cancel it
    this.cancelPendingDraw();

    if (this.shouldUpdateInPlace()) {
        this.redrawInPlace(callback);
        return;
    }

    this.hcConfig = this.getConfig();
    logger.debug('config object to be sent to highcharts:', this.hcConfig);
    if (this.hcChart) {