Closed anushjay closed 6 years ago
I suggest that we change reference to partial to temp
To me the logic is:
for each message the reader reads:
append it to a temporary buffer
if partial == False or Timer is up or Size limit is exceeded:
flush temp buffer
@chenziliang Made changes after your review.
@sharonx Made changes as per your request.
@chenziliang @sharonx Made changes so messages are verified for sending before adding to buffer. Please review when you get a chance. All tests are passing.
We can merge the PR first. However, I'd like to see unit tests for tempBuffer.
It is way cleaner right now. LGTM. Thanks !