search

splunk / docker-logging-plugin

Splunk Connect for Docker is a Docker logging plugin that allows docker containers to send their logs directly to Splunk Enterprise or a Splunk Cloud deployment.
Apache License 2.0
63 stars 25 forks source link

Use health check endpoint #19

Closed sharonx closed 6 years ago

sharonx commented 6 years ago

closes #18

chenziliang commented 6 years ago

Changes look good to me. Questions are

  1. Does this really help customer ?
  2. When container scales out and if splunk is temporary not available at that time, does this feature prevent from scaling out the containers which impacts production service ?

If this feature just for "fail and report quickly", then we can do this at the beginning of running the main logic, and just log connection error in the console, but still allow launching the container

sharonx commented 6 years ago

@chenziliang I had a discussion with David (check out #project-docker-plugin for details). We decided to change the default of verifyConnection to false. So we allows the container to start up regardless of the connection to the endpoint, continue to run and drop logs as necessary until the connection is re-established. Thanks for reviewing and your feedback!