search

splunk / eventgen

Splunk Event Generator: Eventgen
Apache License 2.0
380 stars 179 forks source link

Docker file enhancements #272

Closed ryanfaircloth closed 5 years ago

ryanfaircloth commented 5 years ago

Remove ssh and developer cruft Use multi layer build to package eventgen TODO: swtich to py2 base image and use redis in a dedicated container

ryanfaircloth commented 5 years ago

Agree I had that on my branch for my needs I forgot the PR would update

From: Tony Lee notifications@github.com Reply-To: splunk/eventgen reply@reply.github.com Date: Monday, July 22, 2019 at 5:09 PM To: splunk/eventgen eventgen@noreply.github.com Cc: Ryan Faircloth rfaircloth@splunk.com, Author author@noreply.github.com Subject: Re: [splunk/eventgen] Docker file enhancements (#272)

@arctan5x commented on this pull request.

In .circleci/config.ymlhttps://github.com/splunk/eventgen/pull/272#discussion_r306034201:

@@ -24,10 +24,39 @@ jobs:

       path: /home/circleci/project/tests/test-reports

   - store_artifacts:

       path: /home/circleci/project/htmlcov

I do not think it would be suitable to add your Docker build process in the EventgenCI. I would recommend creating a separate CI pipeline that pulls from this repo for your personal use case.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/splunk/eventgen/pull/272?email_source=notifications&email_token=AIN6WOB76CXXBKEA3GP3W43QAYOZ7A5CNFSM4IFOK572YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB7GHTMY#pullrequestreview-265058739, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AIN6WOAN4FMSGGLIATMYDVTQAYOZ7ANCNFSM4IFOK57Q.

arctan5x commented 5 years ago

Hi Ryan, would this PR be still valid? If not may I close it?

ryanfaircloth commented 5 years ago

Close it I will re-submit

From: Tony Lee notifications@github.com Reply-To: splunk/eventgen reply@reply.github.com Date: Tuesday, July 30, 2019 at 5:49 PM To: splunk/eventgen eventgen@noreply.github.com Cc: Ryan Faircloth rfaircloth@splunk.com, Author author@noreply.github.com Subject: Re: [splunk/eventgen] Docker file enhancements (#272)

Hi Ryan, would this PR be still valid? If not may I close it?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/splunk/eventgen/pull/272?email_source=notifications&email_token=AIN6WOBGTJQSAOFPTWMX6TLQCCZOLA5CNFSM4IFOK572YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3FNJ3Y#issuecomment-516609263, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AIN6WOBVXXTMW6XSHV4ZN23QCCZOLANCNFSM4IFOK57Q.