search

splunk / github_app_for_splunk

A collection of dashboards and knowledge objects for Github data
MIT License
30 stars 25 forks source link

Workflow Analytics Tab: Should it be `queueTime` instead of `queTime` #28

Closed rajbos closed 2 years ago

rajbos commented 2 years ago

Describe the bug Workflow Analytics Tab: Should it be queueTime instead of queTime in the overview pane? Not native English speaker, but it stood out to me.

To Reproduce Steps to reproduce the behavior:

  1. Go to the workflow analytics and see the naming there :-D

Expected behavior Change the naming if that should be the correct text

Screenshots

Desktop (please complete the following information):

Additional context I think the definition file is here: https://github.com/splunk/github_app_for_splunk/blob/main/github_app_for_splunk/default/data/ui/views/workflow_analytics.xml

If it helps and someone thinks we should change the 'field' title, I can create a PR for it?

leftrightleft commented 2 years ago

I think this change makes sense. Good catch, @rajbos! @derkkila-splunk you got any thoughts on this change?

derkkila-splunk commented 2 years ago

Sure, sounds good to me! @rajbos Feel free to create a PR with that change.